Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdamとEveのfoo()がsuper.foo()を呼び出しておらず、またreadme.mdのコードブロックではAdam.foo()/Eve.foo()という自己呼び出しになっていました。people.foo()のイベントログがGodを経由せず、superによる C3 リニアライゼーションの説明と一致しません。super.foo()呼び出しを追加し、readmeのサンプルもsuper.foo()に統一します。super.foo()を正しく使っており、日本語版のみ取り残されていたので、説明を他の言語と整合させます。Files changed
Languages/ja/13_Inheritance_ja/DiamondInheritance.sol:Adam.foo/Eve.fooにsuper.foo()を追加。Languages/ja/13_Inheritance_ja/readme.md: コードブロック内のAdam.foo()/Eve.foo()をsuper.foo()に置換。Test plan
solc0.8 系でDiamondInheritance.solをコンパイルできることを確認。peopleをデプロイし、people.foo()を呼ぶとAdam.foo called -> Eve.foo called -> God.foo calledの順でLogが出ることを確認 (bar()と同じ C3 順)。🤖 Generated with subagent fallback (no external worker output available for this slice).