fix: handle missing config file in load_config() - #126
Open
sirEven wants to merge 1 commit into
Open
Conversation
load_config() now returns a default configuration instead of crashing with FileNotFoundError when ~/.config/task-cli/config.yaml is missing. Fixes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2
load_config()crashed withFileNotFoundErrorwhen~/.config/task-cli/config.yamlwas missing.Changes
load_config()— returns a sensible default config string when the file is missing instead of crashingtest_load_config_missing_file_returns_default: ensures no crash when config is absenttest_load_config_existing_file: ensures normal file reading still worksRoot Cause
load_config()calledopen(config_path)without checking if the file exists, raising an unhandledFileNotFoundError.Fix
Return a default configuration when the config file is missing, matching the format in
config.yaml.example.All 4 tests pass with no regressions.