bindings/python: align max_connections default with engine #5352 (16 -> 32) + document Vamana semantics - #5355
bindings/python: align max_connections default with engine #5352 (16 -> 32) + document Vamana semantics#5355tae898 wants to merge 1 commit into
Conversation
…-20) Regenerated by make-upstream-pr-branch.sh: bindings/python brought to the fork's main state. Scope: the minimum needed to reproduce the wheel build and run the tests and examples.
|
Tick the box to add this pull request to the merge queue (same as
|
There was a problem hiding this comment.
Code Review
This pull request updates the Python bindings and examples. It replaces references to the "real_ladybug" package with "ladybug" in the StackOverflow OLTP and OLAP examples. Additionally, it increases the default value for "max_connections" (or "maxConnections") from 16 to 32 across vector index building, hybrid queries, and the core embedded API, updating the corresponding documentation and help messages to reflect this change and explain its relation to JVector/Vamana per-layer degree. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Follows up #5352: the Python wrapper (
create_vector_index) carried its ownmax_connections=16default, now inconsistent with the engine's new default of 32. This aligns the wrapper and updates all bindings docs/examples with the documented semantics (per-layer Vamana degree, not hnswlib M; use 2*M to reproduce an hnswlib configuration).🤖 Generated with Claude Code
https://claude.ai/code/session_01KPPtpXXDs5EZFmx9DAPnRB