Skip to content

bindings/python: align max_connections default with engine #5352 (16 -> 32) + document Vamana semantics - #5355

Open
tae898 wants to merge 1 commit into
ArcadeData:mainfrom
humemai:python-bindings
Open

bindings/python: align max_connections default with engine #5352 (16 -> 32) + document Vamana semantics#5355
tae898 wants to merge 1 commit into
ArcadeData:mainfrom
humemai:python-bindings

Conversation

@tae898

@tae898 tae898 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Follows up #5352: the Python wrapper (create_vector_index) carried its own max_connections=16 default, now inconsistent with the engine's new default of 32. This aligns the wrapper and updates all bindings docs/examples with the documented semantics (per-layer Vamana degree, not hnswlib M; use 2*M to reproduce an hnswlib configuration).

  • wrapper default 16 -> 32, docstring documents the 2*M mapping
  • docs (api/vector, api/schema, api/database, guide/vectors, testing) and examples 11/13 updated
  • full suite green (353 passed)

🤖 Generated with Claude Code

https://claude.ai/code/session_01KPPtpXXDs5EZFmx9DAPnRB

…-20)

Regenerated by make-upstream-pr-branch.sh: bindings/python brought to the fork's main state. Scope: the minimum needed to reproduce the wheel build and run the tests and examples.
@mergify

mergify Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Python bindings and examples. It replaces references to the "real_ladybug" package with "ladybug" in the StackOverflow OLTP and OLAP examples. Additionally, it increases the default value for "max_connections" (or "maxConnections") from 16 to 32 across vector index building, hybrid queries, and the core embedded API, updating the corresponding documentation and help messages to reflect this change and explain its relation to JVector/Vamana per-layer degree. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@lvca
lvca requested a review from robfrank July 20, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant