chore(deps): bump base64 from 0.22.1 to 0.23.0 - #58
Conversation
Bumps [base64](https://github.com/marshallpierce/rust-base64) from 0.22.1 to 0.23.0. - [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md) - [Commits](marshallpierce/rust-base64@v0.22.1...v0.23.0) --- updated-dependencies: - dependency-name: base64 dependency-version: 0.23.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
0.23 added `simd-unsafe` (runtime-detected AVX2/NEON engines) to its default features; 0.22's default was `std` alone. We only ever construct the scalar `general_purpose::STANDARD` engine, so the SIMD paths are compiled but never called — `default-features = false` + `std` keeps the default build to exactly the code we use. Worth revisiting deliberately rather than by default drift: the telephony serializers base64 every 20 ms carrier frame, so switching those call sites to the `Simd` engine is a real optimization, but it needs measuring and an explicit engine change, not just the feature flag.
|
Checked before merging. The API we use is untouched: every call site is One thing the bump smuggled in, which is why this has an extra commit: 0.23 added Worth noting as a real follow-up rather than something to get by accident: the telephony serializers base64 every 20 ms carrier frame, so those call sites are the one place in the tree where the SIMD engines would actually pay. That wants measuring and a deliberate engine swap. Also flagging that this leaves two base64 copies in the default build — Re-ran CI after reconciling with current main. The green on this PR was from July 27, and the lockfile predated both the rubato 4 / tokio-tungstenite 0.30 bumps and #62, so it was satisfying branch protection without having been tested against anything close to the current tree. Verified the merged lock with |
Bumps base64 from 0.22.1 to 0.23.0.
Changelog
Sourced from base64's changelog.
Commits
9e9220av0.23.0870326eMerge pull request #306 from marshallpierce/mp/trailing-bits-docsfbec5f1Document no trailing trailing bits0a23549Merge pull request #305 from marshallpierce/mp/edition-2021f10b7e2Update deps & edition9d21a59Merge pull request #304 from marshallpierce/mp/custom-padding-rebasef70bad2Support custom padding symbols684d79cMerge pull request #301 from marshallpierce/mp/simd-gardening5bf66f2Merge pull request #284 from AbeZbm/add-testsd3831cfFollowups to SIMD workDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)