Localize tests that depended on public endpoints#2215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
CI jobs fail intermittently because a handful of tests execute real requests against public endpoints (google.com, apache.org, microsoft.com, gatling.io), so any outage, rate-limit, or runner without egress reds the whole 3-OS × 4-JDK matrix.
Modification:
Repoint those tests at the existing local Jetty test server (HTTP, HTTPS, redirect and WS-handshake-failure cases), switch unresolvable-host tests to RFC 6761
.invalid, and tag the irreducible real-DNS/proxy tests@Tag("external")— excluded from the default build and opt-in via-Dexternal.tests=true(run nightly).Result:
The standard
mvn testis now fully self-contained and deterministic with no behavioral coverage lost; real-network checks still run nightly behind the opt-in flag.