Skip to content

Bump mysql2 from 3.23.3 to 3.23.4 - #2747

Merged
Akanksha Jain (jainakanksha-msft) merged 4 commits into
mainfrom
dependabot/npm_and_yarn/mysql2-3.23.4
Aug 25, 2026
Merged

Bump mysql2 from 3.23.3 to 3.23.4#2747
Akanksha Jain (jainakanksha-msft) merged 4 commits into
mainfrom
dependabot/npm_and_yarn/mysql2-3.23.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 24, 2026

Copy link
Copy Markdown
Contributor

Bumps mysql2 from 3.23.3 to 3.23.4.

Release notes

Sourced from mysql2's releases.

v3.23.4

3.23.4 (2026-08-19)

Bug Fixes

  • keep leading zeros in TIME fractional seconds (#4481) (3cccf4a)
  • typings: align callback Pool and PoolConnection types with runtime (#4478) (8b1f829)
Changelog

Sourced from mysql2's changelog.

3.23.4 (2026-08-19)

Bug Fixes

  • keep leading zeros in TIME fractional seconds (#4481) (3cccf4a)
  • typings: align callback Pool and PoolConnection types with runtime (#4478) (8b1f829)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.23.3 to 3.23.4.
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](sidorares/node-mysql2@v3.23.3...v3.23.4)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-version: 3.23.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 24, 2026
Copilot AI lite review requested due to automatic review settings August 24, 2026 18:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jainakanksha-msft

Copy link
Copy Markdown
Member

Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:

  1. Impact analysis — identify what changed (package name, old → new version) from the PR diff/description, search the codebase for where that dependency is actually used, and summarize what could be affected.
  2. Fix build/conflict issues — run npm ci --legacy-peer-deps, npm run build, and npm run lint; resolve any merge conflicts, build errors, or lint errors that surface.
  3. Tests — add or update tests under tests/** to cover the changed usage, and make sure they meaningfully validate the change (not just re-assert the version bump).
  4. Run the suite — run the relevant npm run test:* script(s) for the affected area (e.g. test:blob, test:queue, test:table) and keep fixing until they pass.
  5. Changelog — append one bullet to ChangeLog.md under ## Upcoming ReleaseGeneral:, matching the existing style and tone of the entries already there (package name in backticks, old → new version, why, and a one-line concise summary of any code changes made).
  6. Comments — review any existing PR comments and review threads, including resolved/hidden ones, and address anything actionable.
  7. Self-rate — rate this work 1-10 against: correctness, test coverage, changelog accuracy, build/lint health, and comment resolution.
  8. Iterate — if it's not a 10, keep improving until it is before finishing.
  9. Summary — post a final comment explaining why this update matters, what the impact/risk is, and what could go wrong if it weren't applied, along with your self-rating and reasoning.

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 24, 2026 18:39
@dependabot
dependabot Bot removed the request for review from Copilot August 24, 2026 18:39

Copilot AI commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:

  1. Impact analysis — identify what changed (package name, old → new version) ...

Done. Summary:

  1. Impact: mysql2 3.23.3 → 3.23.4 fixes leading-zero truncation on TIME fractional seconds and aligns callback Pool/PoolConnection typings with runtime. It's used only as the MySQL driver behind Sequelize in sqlBlobMetadataStore; Azurite doesn't parse raw TIME values through this path, so no source changes were needed.
  2. Build/lint: npm ci --legacy-peer-deps, npm run build, npm run lint all pass.
  3. Tests: existing tests/blob/unit/sqlBlobMetadataStore.unit.test.ts and tests/blob/sqlBlobMetadataStorePool.test.ts (added in the prior mysql2 bump) already cover driver load/escaping and were re-verified; no new Azurite behavior was introduced by this patch so no additional tests were added.
  4. Suite: npm run test:blob — 549 passing, 3 pre-existing pending, no regressions.
  5. Changelog: added a bullet under Upcoming ReleaseGeneral: in ChangeLog.md (commit 1a1... see latest push).

Self-rating: 9/10 (build/lint/tests green, changelog added, impact analyzed; not a 10 since there's no new Azurite-level test to add for this narrow driver-internal fix).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Comment thread ChangeLog.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 25, 2026 06:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 25, 2026 06:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

@jainakanksha-msft
Akanksha Jain (jainakanksha-msft) merged commit 826a978 into main Aug 25, 2026
46 checks passed
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/mysql2-3.23.4 branch August 25, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants