[DONT MERGE ][documentdb] Rename mongocluster administrator password option to --password#1044
Draft
amatarritamicrosoft wants to merge 6 commits into
Draft
[DONT MERGE ][documentdb] Rename mongocluster administrator password option to --password#1044amatarritamicrosoft wants to merge 6 commits into
amatarritamicrosoft wants to merge 6 commits into
Conversation
Update the mongoCluster create and update command model so the administrator password argument uses --password/-p, matching the reset-password and restore commands in the extension. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bf5e49a-3c3e-4dfe-851d-1f2790a2852b
amatarritamicrosoft
changed the title
…word arg Add the admin-password option back alongside password and p so the administrator password argument exposes all three aliases on both create and update, matching the reset-password command and peer resource providers. This addresses PR review feedback asking for a consistent alias set on both sides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bf5e49a-3c3e-4dfe-851d-1f2790a2852b
The mongoClusters users API only accepts Microsoft Entra ID principals, so the generic `user` naming is misleading. Rename the command group to `entra-user` and the identifier arg to `--object-id` (keeps -n/--name), with Entra-specific help stating the value is the Entra object (client) ID. Also fix the show help typo and the roles singular option (was `--role`, which the generator turned into ----role). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40a4fbc4-fd62-4bcc-9b7d-6e70f80e114d
Per Oliver Towers' review: an entra-user binding grants an already-existing Microsoft Entra principal data-plane access to the cluster, rather than creating a new user, so assign/remove sets the right expectation and matches the sibling `mongocluster identity assign/remove`. Renames the create command to `assign` and delete to `remove` (verbs only; the group and update/show/list stay). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40a4fbc4-fd62-4bcc-9b7d-6e70f80e114d
Set stage=Preview on all documentdb mongocluster commands so the generated code and reference docs show Preview instead of GA. Also update the root and mongocluster group help to the Azure DocumentDB branding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40a4fbc4-fd62-4bcc-9b7d-6e70f80e114d
Rename the replica list argument option from cluster-name to parent-cluster-name so it clearly refers to the parent cluster, per review feedback. Updates the command example, the group readme, and the replicas resource model. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40a4fbc4-fd62-4bcc-9b7d-6e70f80e114d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the mongocluster administrator password option from
--admin-passwordto--password, for consistency with the reset-password and restore commands and with peer database CLIs (sql, mysql, postgres).Change
Updates the DocumentDB mongocluster model for api-version 2026-06-01 so the administrator password argument is exposed as
--password/-p.This model change pairs with the regenerated extension code in the matching azure-cli-extensions follow-up.
Raised from PR #10059 review feedback.