Preserve displayName and description after WSDL import - #874
Open
SiebeCorstjens wants to merge 1 commit into
Open
Preserve displayName and description after WSDL import#874SiebeCorstjens wants to merge 1 commit into
SiebeCorstjens wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When publishing a SOAP API using a WSDL specification file, APIM's WSDL import process re-derives certain API properties, specifically
displayNameanddescription, from the WSDL binding name and overwrites the original values configured for the API (e.g. viaapiInformation.json). This causes unexpected metadata drift on every publish run for a SOAP API.Solution
In
putWsdlSpecification(src/common/ApiSpecification.cs), the originaldisplayNameand
descriptionare now:GetResourceDtoFromApim) before theWSDL specification import is performed.
ApiRevisionModule.IsRootName), since non-root revisions do not independently own these properties.descriptionordisplayName) was present beforehand, avoiding unnecessary API calls.