Skip to content

[ACR] enable writableCacheRepos for CLI#33772

Open
mabelegba wants to merge 4 commits into
Azure:devfrom
mabelegba:writableCacheRepos
Open

[ACR] enable writableCacheRepos for CLI#33772
mabelegba wants to merge 4 commits into
Azure:devfrom
mabelegba:writableCacheRepos

Conversation

@mabelegba

@mabelegba mabelegba commented Jul 22, 2026

Copy link
Copy Markdown

Related command
az acr create
az acr update

Description
Add new flag to enable writable behavior for cache repositories within a registry.

flag: --writable_cache_repo
arg: enable/disable

default behavior is disabled

Testing Guide
manual az acr create and update commands

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes Tests
⚠️ None ️✔️ 130/130
⚠️AzureCLI-BreakingChangeTest
⚠️acr
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd acr create cmd acr create added parameter writable_cache_repos
⚠️ 1006 - ParaAdd acr update cmd acr update added parameter writable_cache_repos

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi @mabelegba,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@yonzhan

yonzhan commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

ACR

@a0x1ab

a0x1ab commented Jul 23, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@mabelegba
mabelegba marked this pull request as ready for review July 23, 2026 02:09
@mabelegba
mabelegba requested review from a team as code owners July 23, 2026 02:09
Copilot AI review requested due to automatic review settings July 23, 2026 02:09
@mabelegba
mabelegba requested review from a team as code owners July 23, 2026 02:09
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support in the ACR command module to configure the registry’s writable cache repositories setting via az acr create and az acr update, with accompanying help/history updates and an SDK dependency bump to expose the needed model/field.

Changes:

  • Add --writable-cache-repo argument to az acr create and az acr update and plumb it into the registry model (writable_cache_repos).
  • Update ACR help examples and HISTORY.rst to document the new parameter.
  • Bump azure-mgmt-containerregistry pinned version from 15.1.0b1 to 15.1.0b2 in packaging requirement sources.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/azure-cli/setup.py Bumps azure-mgmt-containerregistry pin used for packaging/install.
src/azure-cli/requirements.py3.windows.txt Updates Windows pinned dependency version for azure-mgmt-containerregistry.
src/azure-cli/requirements.py3.Darwin.txt Updates macOS pinned dependency version for azure-mgmt-containerregistry.
src/azure-cli/HISTORY.rst Adds history notes for the new ACR create/update parameter.
src/azure-cli/azure/cli/command_modules/acr/custom.py Wires the new argument into create/update request payloads.
src/azure-cli/azure/cli/command_modules/acr/_params.py Defines the new CLI argument for create/update.
src/azure-cli/azure/cli/command_modules/acr/_help.py Adds usage examples for the new parameter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/azure-cli/azure/cli/command_modules/acr/custom.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/acr/_params.py Outdated
@a0x1ab

a0x1ab commented Jul 24, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@mabelegba
mabelegba changed the base branch from dev to main July 24, 2026 22:57
@mabelegba
mabelegba requested review from a team and FumingZhang as code owners July 24, 2026 22:57
@mabelegba
mabelegba changed the base branch from main to dev July 24, 2026 22:57
@a0x1ab

a0x1ab commented Jul 25, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@mabelegba
mabelegba force-pushed the writableCacheRepos branch from 6aa4fcd to 55d33b9 Compare July 26, 2026 19:26
@a0x1ab

a0x1ab commented Jul 26, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

mabelegba added 2 commits July 26, 2026 19:17
mark writable-cache-repos create tests as live_only
pin azure-mgmt-containerregistry 15.1.0b2 in Linux requirements
@mabelegba
mabelegba force-pushed the writableCacheRepos branch from 5b7ffff to e15dc6c Compare July 26, 2026 23:39
@Sebby37

Sebby37 commented Jul 27, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants