Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain, and all readiness assessments support approval.
Pull request overview
Updates packaging to use Scalelib 1.0.12 and automatically obtain the bundled CycleCloud API wheel.
Changes:
- Extracts and packages the API wheel from Scalelib.
- Removes the separately managed API wheel asset.
- Updates release uploads and packaging tests.
File summaries
| File | Description |
|---|---|
test_packaging/test_package.py |
Tests extraction, overrides, validation, and legacy downloads. |
project.ini |
Removes the separately managed API wheel asset. |
package.py |
Downloads Scalelib and extracts the API wheel. |
.github/workflows/release.yml |
Uploads the versioned API wheel as a release asset. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ryanhamel
force-pushed
the
ryhamel/scalelib-1.0.12
branch
from
September 17, 2026 16:18
3800332 to
157c63a
Compare
ryanhamel
requested review from
Jelena Gvero (jgvero32)
and
a lite review from Copilot
September 17, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalelib 1.0.12 now includes the cyclecloud_api wheel, so packaging pulls that in automatically.