Add run_tests.sh and fix single broken test - #99
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fix environment recreation or clearing in run_tests.sh before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a standalone test runner, mocks PBS commands in a driver test, and ignores the generated environment.
Changes:
- Added
run_tests.shfor isolated test execution. - Updated the driver test to avoid external PBS binaries.
- Added
.testenvto.gitignore.
File summaries
| File | Summary |
|---|---|
run_tests.sh |
Creates the test environment and runs tests; moderate issue (2 votes): existing environments may be reused, making PYTHON overrides ineffective. |
pbspro/test/pbspro_test/driver_test.py |
Mocks PBS command interactions in the test. |
.gitignore |
Ignores the generated .testenv directory. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Jelena Gvero (jgvero32)
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.