Skip to content

fix: validate --env is not passed with an empty string #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjk7989 merged 3 commits into from
Jul 16, 2026
Merged

fix: validate --env is not passed with an empty string #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d2b1f2
fix: validate --env is not passed with an empty string
monteiro-renato Jun 5, 2026
80b4304
add the validation sooner, closer to other input checks
monteiro-renato Jul 15, 2026
13b2e46
make the check even earlier
monteiro-renato Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cli/commands/deploy/deploy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,5 +307,13 @@ describe("deploy", () => {
expect(env.FUNCTION_LANGUAGE_VERSION).toBe(DEFAULT_VERSION.DotnetIsolated);
expect(SUPPORTED_VERSIONS.DotnetIsolated).toContain(env.FUNCTION_LANGUAGE_VERSION);
});

it("should print an error when --env is an empty string", async () => {
await deploy({
outputLocation: "/test-output",
env: "",
});
expect(logger.error).toHaveBeenNthCalledWith(1, "Invalid --env: cannot be empty. Use a named environment (e.g. 'preview') or omit the flag.");
});
});
});
6 changes: 6 additions & 0 deletions src/cli/commands/deploy/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ export async function deploy(options: SWACLIConfig) {
}
}

// make sure --env is not an empty string
if (options.env !== undefined && !options.env.trim()) {
logger.error("Invalid --env: cannot be empty. Use a named environment (e.g. 'preview') or omit the flag.");
return;
}

logger.silly(`Resolving outputLocation=${outputLocation} full path...`);
let resolvedOutputLocation = path.resolve(appLocation, outputLocation as string);

Expand Down
Loading