validate_workload: don't fail on scaled-to-zero workloads or vanished pods#1252
Open
xinWeiWei24 wants to merge 2 commits into
Open
validate_workload: don't fail on scaled-to-zero workloads or vanished pods#1252xinWeiWei24 wants to merge 2 commits into
xinWeiWei24 wants to merge 2 commits into
Conversation
xinWeiWei24
requested review from
liyu-ma,
vittoriasalim and
wonderyl
as code owners
July 10, 2026 06:04
vittoriasalim
approved these changes
Jul 13, 2026
liyu-ma
reviewed
Jul 14, 2026
| # The pod list is a snapshot; a pod may be deleted before we inspect it | ||
| # (e.g. rollout, eviction, completed Job pod). A gone pod is not a failure, | ||
| # so skip it instead of reporting an empty phase. | ||
| if ! kubectl -n "${namespace}" get pod "$pod" -o name >/dev/null 2>&1; then |
Collaborator
There was a problem hiding this comment.
Would this run into an infinite loop if pods are deleted during the check
wonderyl
reviewed
Jul 14, 2026
| # The pod list is a snapshot; a pod may be deleted before we inspect it | ||
| # (e.g. rollout, eviction, completed Job pod). A gone pod is not a failure, | ||
| # so skip it instead of reporting an empty phase. | ||
| if ! kubectl -n "${namespace}" get pod "$pod" -o name >/dev/null 2>&1; then |
Collaborator
There was a problem hiding this comment.
It looks like you only use kubectl get pod, it is possible to do this? dump all the required info of all pods into a json file, then look up the json file to decide. In this case you only talk to kube-apiserver once, thus avoids the inconsistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.