feat(morecolors): SM 1.13 compatibility - #23
Open
Rushaway wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourcePawn 1.13 introduced native
int64support.As a side effect, integer literals that exceed the 32-bit signed range (
INT_MAX = 2147483647) are now promoted toint64.The FNV-1a offset basis
2166136261(0x811C9DC5) falls into this category, causing:Replace the decimal literal with its hexadecimal equivalent
0x811C9DC5.Hex literals are interpreted as raw 32-bit cells by the compiler, bypassing the promotion logic, while remaining bit-for-bit identical at runtime.
You can see the error here: https://github.com/Bara/Multi-Colors/actions/runs/27945429432/job/82688810583?pr=22