Handle function pointer types in constant array struct naming#4
Open
deathbeam wants to merge 2 commits into
Open
Handle function pointer types in constant array struct naming#4deathbeam wants to merge 2 commits into
deathbeam wants to merge 2 commits into
Conversation
Use GetTypeIdentifier instead of GetTypeName for the array size suffix to ensure the generated struct name is always a valid C# identifier. This prevents invalid identifiers when the element type is a function pointer or other non-identifier-compatible type. Also derive the struct name from GetTypeName(type) directly rather than constructing it manually, which correctly handles complex types. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
force-pushed
the
fix-binding-generator
branch
from
d5c18ef to
1c44213
Compare
Author
|
Simplified the PR a bit |
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GetTypeIdentifier instead of GetTypeName for the array size suffix
to ensure the generated struct name is always a valid C# identifier.
This prevents invalid identifiers when the element type is a function
pointer or other non-identifier-compatible type.
Also derive the struct name from GetTypeName(type) directly rather than
constructing it manually, which correctly handles complex types.
Signed-off-by: Tomas Slusny slusnucky@gmail.com