Convert all locale files to MiniMessage - #555
Merged
Merged
Conversation
BentoBox text is MiniMessage now; the &-codes still parse, but leaving
the files in the old format is what makes formatting bugs possible —
anything that builds a fragment and puts it into a translation has to
guess which format the target line is in.
Converted with BentoBox's own Util.legacyToMiniMessage, so each value
now says exactly what the runtime was already rendering, then tidied up:
a straight conversion closes and immediately reopens a tag wherever the
old text repeated a colour code, which is every line of a multi-line
description.
Verified by rendering all 1506 values before and after and comparing the
style of every character: no value moved. Placeholder checks report the
same 47 pre-existing issues as before, none new. Tests green.
Ten values across vi, tr, it, es, fr, uk and ja were left alone: they
contain a broken colour code ("& c", "&un", "& l") that never rendered
as colour and still doesn't. Worth a translator's eye, separately.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017EZEwab2kL4i1FNnBYvSmp
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BentoBox text is MiniMessage now. The old
&-codes still parse, so nothing is broken today — but leaving the files in the legacy format is what makes formatting bugs possible: any code that builds a fragment and drops it into a translation has to guess which format the target line is written in, and guessing wrong renders colour codes as literal text. (That is exactly the bug this started as, in ChunkBlock's chunk map.)All 18 locale files are now MiniMessage.
How
Converted with BentoBox's own
Util.legacyToMiniMessage, so each value now literally says what the runtime was already rendering — nothing hand-translated. Then tidied: a straight conversion closes and immediately reopens a tag wherever the old text repeated a colour code (every line of a multi-line flag description, every run split by a placeholder), so those</aqua><aqua>seams are closed up.Verification
<bold>inside<green>rather than the reverse, which is the same thing to a player.)wrap-at: '50') survive the round trip.Left alone deliberately
Ten values in vi, tr, it, es, fr, uk and ja contain a broken colour code —
& c,& l,&un bloc— that never rendered as colour. They still render as literal text, exactly as today. Fixing them changes what players see, so that is a translator's call, not this PR's.Related
Same migration in ChunkBlock: BentoBoxWorld/ChunkBlock#33, where the shared locale strings came from.
🤖 Generated with Claude Code
https://claude.ai/code/session_017EZEwab2kL4i1FNnBYvSmp