Withdraw an addon's commands when the addon never enables

[tastybento]

Fixes #3059.

Reported on Discord: a player ran /ch on a server with ChunkBlock installed but not the Level addon it depends on, and every subcommand answered "An unexpected error occurred while running the command" with an NPE in the console.

The bug

A game mode addon builds its commands in onLoad(), and CompositeCommand's constructor registers them with the Bukkit command map the moment they are constructed. The world is only attached much later, in AddonsManager#enableAddon:

gameMode.getPlayerCommand().ifPresent(c -> c.setWorld(gameMode.getOverWorld()));

sortAddons() spots the missing dependency after onLoad() has run. It set the state to MISSING_DEPENDENCY, unregistered the addon's flags and dropped it from the addon list — so enableAddon never ran — but it left the commands registered. /ch stayed live with getWorld() == null, and IslandWorldManager.getWorldSettings(null) threw on the first lookup.

The same hole existed for an addon abandoned because it is incompatible, or because it threw during onLoad/onEnable: whatever it registered on the way up stayed behind.

The fix

AddonsManager#withdrawAddon takes back everything an addon registered on its way up — listeners, flags and commands — and is now called from all three abandonment paths (missing dependency, incompatibility, unhandled exception during load or enable). Previously only flags were unregistered, and only on the missing-dependency path.

CommandsManager#unregisterCommands(Addon) is the new method backing that: it pulls the addon's top level commands out of the internal map and the Bukkit command map. Brigadier keeps its nodes, since it has no removal API, but a node whose label no longer resolves to a command is refused by its requires predicate and does nothing if run anyway, so it disappears from clients too.

CompositeCommand#call refuses outright when a command belongs to a GameModeAddon and has no world, sending general.errors.general and logging which addon is not enabled. Defence in depth for any path the above misses. BentoBox's own world-less commands such as /bentobox are not affected.

IslandWorldManager#getWorldSettings now builds its "non-game world" message lazily. It used to evaluate world.getName() eagerly, so a null world threw inside the very string meant to explain the problem — which is why the report showed a bare NPE with no useful message.

API

CommandsManager#unregisterCommands(Addon) is new and additive, so binary compatibility with existing addons is unaffected.

Tests

• GameModeCommandWithoutWorldTest — new: a world-less game mode command is refused rather than throwing, tells the player, applies to sub-commands, and does not catch non-game-mode commands.
• AddonsManagerTest — a missing dependency unregisters the addon's commands; a satisfied one does not.
• CommandsManagerTest — per-addon unregister removes that addon's commands from the command map, leaves other addons alone, and is safe for an addon with no commands.

Full suite passes.

Version

Bumped buildVersion to 3.22.2.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JJPRnxgoMiVypeN21uRFW4

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud