Do not put texture-less profiles on player heads

[tastybento]

Problem

Opening a panel full of player heads (a top ten, for example) can spam the console with:

[WARN]: Couldn't look up profile properties for c44d4387-e438-4880-bb8a-4e267340feda
MinecraftClientHttpException[type=HTTP_ERROR, status=429, response=null]
	at com.mojang.authlib.minecraft.client.MinecraftClient.buildHttpException(MinecraftClient.java:160)
	...
	at com.destroystokyo.paper.profile.PaperMinecraftSessionService.fetchProfile(PaperMinecraftSessionService.java:40)
	at org.bukkit.craftbukkit.profile.CraftPlayerProfile.getUpdatedProfile(CraftPlayerProfile.java:157)

Those lookups are made by the server, not by us. A PlayerProfile that carries a UUID and a name but no textures property is incomplete, so the server resolves it against the Mojang session server every time the head is shown — see PaperMC/Paper#13727 and the discussion on PaperMC/Paper#13692. Ten heads in a panel is ten lookups per open, which reaches HTTP 429 quickly and still renders a default skin at the end of it.

HeadGetter produces precisely that profile whenever its own texture fetch comes back empty: createProfile() always returns a profile, with or without a skin, and getTextureFromUUID() swallows every failure and returns null. It then hands the result to requesters regardless, because the check guarding delivery —

// Tell requesters the head came in, but only if the texture is usable.
if (cache.playerProfile != null && HeadGetter.headRequesters.containsKey(userName)) {

— tests for a null profile, which createProfile() never returns. The comment describes an intent the code never implemented.

The failed lookup was also written straight over the cache, so one rate-limited call replaced a working head with a broken one for the whole cache period. Since the broken profile then triggers a fresh server-side lookup on every panel open, the failure sustains itself.

Changes

• HeadCache gains hasTexture(), and getPlayerHead() only calls setOwnerProfile() when a skin is actually known. With no profile attached there is nothing for the server to resolve, so a failed lookup degrades to a plain head instead of one that keeps hitting Mojang.
• HeadGetter only notifies requesters when the texture is usable, making the existing comment true, and no longer lets a failed fetch evict a cached head that already has a texture.

No API is removed; hasTexture() is additive.

Testing

./gradlew compileJava is clean and PanelTest, which exercises HeadGetter, passes. Other *PanelTest classes in the tree fail identically before and after this change (UnfinishedStubbingException during static init), unrelated to heads.

Note for server owners

Setting use-cache-server: true is still worth doing independently. The defaults (heads-per-call: 9, ticks-between-calls: 10) allow roughly 18 direct requests per second to sessionserver.mojang.com from BentoBox's own fetcher, which is enough to trip the rate limit that starts this cycle.

🤖 Generated with Claude Code

https://claude.ai/code/session_014HtnKzNE649pBrCdqMm7nw

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud