Skip to content

feat: add needsXpubsForColdSigning capability method - #9430

Merged
davidkaplanbitgo merged 1 commit into
masterfrom
davidkaplan/wcn-1799-remove-xpubs-from-ovc-transaction-downloads-for-cold-utxo
Aug 7, 2026
Merged

feat: add needsXpubsForColdSigning capability method#9430
davidkaplanbitgo merged 1 commit into
masterfrom
davidkaplan/wcn-1799-remove-xpubs-from-ovc-transaction-downloads-for-cold-utxo

Conversation

@davidkaplanbitgo

Copy link
Copy Markdown
Contributor

Adds a coin-level capability so callers can check whether a built transaction requires xpubs/derivation paths for cold signing instead of sniffing tx format themselves. PSBT transactions carry BIP-32 derivation info inline, so xpubs are only needed for legacy UTXO txs.

TICKET: WCN-1799

@linear-code

linear-code Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

WCN-1799

@davidkaplanbitgo
davidkaplanbitgo marked this pull request as ready for review August 5, 2026 19:35
@davidkaplanbitgo
davidkaplanbitgo requested review from a team as code owners August 5, 2026 19:35
Comment thread modules/sdk-core/src/bitgo/baseCoin/baseCoin.ts
lcovar
lcovar previously approved these changes Aug 5, 2026
@davidkaplanbitgo
davidkaplanbitgo force-pushed the davidkaplan/wcn-1799-remove-xpubs-from-ovc-transaction-downloads-for-cold-utxo branch 2 times, most recently from 923e1c6 to f9e5964 Compare August 5, 2026 20:33
lcovar
lcovar previously approved these changes Aug 5, 2026
Comment thread modules/sdk-core/src/bitgo/baseCoin/baseCoin.ts
@davidkaplanbitgo
davidkaplanbitgo force-pushed the davidkaplan/wcn-1799-remove-xpubs-from-ovc-transaction-downloads-for-cold-utxo branch from f9e5964 to 02b1d4d Compare August 6, 2026 16:55
Adds a coin-level capability so callers can check whether a built
transaction requires xpubs/derivation paths for cold signing instead
of sniffing tx format themselves. PSBT transactions carry BIP-32
derivation info inline, so xpubs are only needed for legacy UTXO txs

TICKET: WCN-1799
@davidkaplanbitgo
davidkaplanbitgo force-pushed the davidkaplan/wcn-1799-remove-xpubs-from-ovc-transaction-downloads-for-cold-utxo branch from 02b1d4d to 9b7024d Compare August 7, 2026 12:59
@davidkaplanbitgo
davidkaplanbitgo merged commit b87841a into master Aug 7, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants