feat(dashboard): add ephemeral invitation links - #159
Merged
Merged
Conversation
Contributor
Author
|
This pull request was created from a Blocks session. |
tomi-stipancik
marked this pull request as ready for review
September 16, 2026 21:10
tomi-stipancik
enabled auto-merge (squash)
September 16, 2026 21:10
tomi-stipancik
previously approved these changes
Sep 16, 2026
![blocksorg[bot]](https://avatars.githubusercontent.com/in/931482?s=60&v=4){kind=small}
| BETTER_AUTH_SECRET: ${BETTER_AUTH_SECRET:-local-development-secret-change-before-production} | ||
| HARNESS_BOOTSTRAP_ADMIN_EMAIL: ${HARNESS_BOOTSTRAP_ADMIN_EMAIL:-admin@example.com} | ||
| HARNESS_BOOTSTRAP_ADMIN_PASSWORD: ${HARNESS_BOOTSTRAP_ADMIN_PASSWORD:-change-me-in-production} | ||
| HARNESS_BOOTSTRAP_ADMIN_PASSWORD: ${HARNESS_BOOTSTRAP_ADMIN_PASSWORD:-change-me-before-testing} |
Contributor
There was a problem hiding this comment.
This default password change looks unrelated to the ephemeral invitation links feature and breaks consistency with the documented local stack. README.md still tells users the bootstrap password is change-me-in-production, and tests/e2e/support/dashboard.ts / tests/e2e/docker-compose.yml also hard-code that value. Unless this is intentionally changing the local default (in which case README and any related docs/tests should be updated), I’d revert it to keep the PR focused.
Severity 7/10 · View on dashboard
Co-authored-by: Blocks Task Runner <tomislav@blocksorg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo check -p control-apiDraft PR. An issue reference was not available in the supplied task context.