Skip to content

fix: fix injl typo in core constructible#369

Open
stringhandler wants to merge 1 commit into
BlockstreamResearch:masterfrom
stringhandler:fix/fix-constructible-injr
Open

fix: fix injl typo in core constructible#369
stringhandler wants to merge 1 commit into
BlockstreamResearch:masterfrom
stringhandler:fix/fix-constructible-injr

Conversation

@stringhandler

Copy link
Copy Markdown
Contributor

Found a simple typo via LLM scanning.

I don't think it's particularly dangerous as we would have seen this by now. I think this API is hardly used

@delta1 delta1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9bc2ae5; tested locally

@apoelstra

Copy link
Copy Markdown
Collaborator

Surprising that no unit tests (or actual usage) have been broken by this. This looks like a convenience API for the policy module. Amusingly, grepping through that module, it looks like we don't use injl or injr anywhere!

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9bc2ae5; successfully ran local tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants