Footer: remove dead Get Involved link - #282
Open
macoyj wants to merge 1 commit into
Open
Conversation
buildcanada.com/get-involved 404s. Follow-up to #278, which removed the same dead link from the nav bar and flagged this one. The "Get Involved" msgid is now unreferenced, so it comes out of en.po and fr.po as well.
Dokploy Preview Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
Get Involvedlink from the site footer. It pointed athttps://buildcanada.com/get-involved, which is the same 404 #278 hit when it removed this link from the nav bar: that page used to explain the Get Involved process, and no longer exists.Verified:
Pulled out entirely rather than repointed, matching the treatment in #278. That PR's "Notes for the reviewer" explicitly flagged
Footer.tsx:46as a remaining link that would hit the same 404 and "likely wants the same treatment" — this is that follow-up.The footer list is now About Us / Contact / Whistleblowers.
i18n
Get Involvedwas a<Trans>string, and the footer was its last remaining reference (#278 already dropped theDesktopNavone). The msgid is therefore orphaned and comes out of bothsrc/locales/en.poandsrc/locales/fr.po(fr:Impliquez-vous).Confirmed against the extractor:
lingui extract --cleanindependently drops the same msgid, so the hand-edit matches what a full extract would produce for this string.Notes for the reviewer
Footer.tsxsource-path comments in the.pofiles shift up by 8 lines and are left stale. This is deliberate: the catalogs already carry ~1175 lines of stale source-path comments from the/spending/*->/federal/spending/*move, and fixing 5 while 1175 stay wrong adds diff noise without value. A fullpnpm extractfixes them all at once and is still worth doing as its own PR.pnpm extractreports 922/922, 4 missing for fr. Those 4 are pre-existing onmainand unrelated to this change: all four come fromsrc/app/[lang]/(main)/tax-visualizer/page.tsxand were introduced by Implement CRA line 22215 deduction for CPP/QPP enhanced contributions #281 (CRA line 22215 CPP/QPP), which merged after Nav: remove dead Get Involved link, switch CTA to Follow Build Canada #278 measured 919/0.src/locales/en.js/fr.jsleft untouched, for the same reason as Nav: remove dead Get Involved link, switch CTA to Follow Build Canada #278: nothing imports them.buildcanada.com/get-involvedstill remain outside the nav and footer, and all hit this same 404. Left alone to keep this PR scoped to the footer, but they want the same treatment:src/app/[lang]/(main)/about/faq.tsx:101src/components/BuildCanadaBanner/index.tsx:41(also still reads "Join Build Canada")src/components/RecruitmentBanner/index.tsx:68(renders the bare URL as text)Test plan
prettier --checkclean onFooter.tsxnext lint --file src/components/MainLayout/Footer.tsx-> no warnings or errorslingui extract --cleanagrees theGet Involvedmsgid is orphaned/frlocale footer renders correctly with the entry gone🤖 Generated with Claude Code