Remove agent evaluation concurrency limits and skip same-day re-evaluation - #132
Merged
Merged
Conversation
- Remove enqueue_limit: 550 from AgentEvaluateCommitmentJob; the weekly scan enqueues ~600 commitments and GoodJob silently dropped the excess - Skip commitments whose last_assessed_at is today unless force: true, so a re-run of the scan or a duplicate manual enqueue doesn't repeat a ~2 minute agent session
With enqueue_limit gone and perform_limit removed there is nothing left for the extension to enforce; concurrency is bounded by the worker thread count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #131, for
AgentEvaluateCommitmentJob:enqueue_limit: 550, but the scan enqueues ~600. GoodJob drops enqueues past the limit without error, so up to ~50 commitments were never evaluated on Sundays.perform_limitalso dropped, the GoodJob concurrency extension had nothing left to enforce. The include, thegood_job_control_concurrency_withblock, and theConcurrencyExceededErrorretry handler are gone. Concurrency is now bounded by the worker thread count (good_job.max_threads, currently 5).last_assessed_atis today unless called withforce: true, so a re-run of the scan or a duplicate manual enqueue doesn't repeat work.Notes
max_threadsis the lever to shorten it.Testing
bin/rubocop— no offenses