✨ Essentials Warp Converter#90
Open
Zoriot wants to merge 4 commits into
Open
Conversation
…ls-warp-converter"" This reverts commit 9c4ce67 Co-authored-by: frikandelworst <66461508+frikandelworst@users.noreply.github.com>
- Updated warp migration to include player-specific context. - Enhanced error handling and messaging for warp creation, ensuring better feedback for players. - Improved region ownership checks and debugging logs for clarity.
Zoriot
added
⏰ medium priority
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
- Add MigrationResult class to track successful and failed migrations - Update migrate() to return detailed result instead of void - Track individual warp migration success/failure counts - Display appropriate messages based on migration outcome: * Success with count when all warps migrate successfully * Partial success showing both migrated and failed counts * Error messages when migration fails completely * Info message when no warps found - Fix issue where "Successfully migrated" was shown even on failures
Zoriot
force-pushed
the
48-essentials-warp-converter
branch
from
13108bb to
c15756d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This features basic migration logic for other warp systems and currently supports migration from EssentialsX. For now, it simply imports all warps into the 'Other' group with the same name.
Other converters could easily be added in the future.
Most of the programming was done by @kyanvde; I just refactored and fixed it.
Open ToDo's: