perf: preallocate snapshot v2 imports - #390
Merged
Merged
Conversation
<!-- agent --> Snapshot V2 prefixes the record stream with the total node count and native path-name bytes. Interactive imports use them for exact reservations while V1 remains readable and declared requirements are validated. ## `~/dev` benchmark `dua i --import SNAPSHOT --once`, release builds; one frozen V1 traversal converted to V2 for identical contents. | Metric | V1 | V2 | Change | | --- | ---: | ---: | ---: | | Median peak RSS (5 runs) | 369,868,800 B | 230,473,728 B | -37.7% | | Mean wall time (20 runs) | 430.5 ± 1.8 ms | 438.1 ± 2.8 ms | +1.8% | | Compressed snapshot size | 38,215,358 B | 38,215,404 B | +46 B | Assisted-by: GPT 5.6 Co-authored-by: GPT 5.6 <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Snapshot V2 prefixes the record stream with the total node count and native
path-name bytes. Interactive imports use them for exact reservations while V1
remains readable and declared requirements are validated.
~/devbenchmarkdua i --import SNAPSHOT --once, release builds; one frozen V1 traversal converted to V2 for identical contents.