Skip to content

feat: add Korean, Chinese, and German help translations #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 6 commits into from
Sep 4, 2026
Merged

feat: add Korean, Chinese, and German help translations #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
793ab72
feat: add Korean help translation
codex Sep 3, 2026
a7835a2
docs: list Korean help locale
codex Sep 3, 2026
7b5e8e4
feat: add Simplified Chinese help translation
codex Sep 3, 2026
4979276
fix: keep Traditional Chinese locales in English
codex Sep 3, 2026
5b5e83f
feat: add German help translation
Byron Sep 3, 2026
c1f5dda
feat: localize the interactive interface
Byron Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,19 @@ dua i
dua interactive
```

The help screen can be localized via the standard POSIX locale environment variables, in the
usual order of precedence `LC_ALL` > `LC_MESSAGES` > `LANG`. English is the default; currently
Japanese (`ja`) is also available when the locale uses UTF-8 or omits the codeset:
The interactive interface can be localized via the standard POSIX locale environment variables,
in the usual order of precedence `LC_ALL` > `LC_MESSAGES` > `LANG`. English is the default; German
(`de`), Japanese (`ja`), Korean (`ko`), and Simplified Chinese (`zh`, `zh_CN`, `zh_SG`, or
`zh_Hans`) are also available when the locale uses UTF-8 or omits the codeset:

Please [open an issue](https://github.com/Byron/dua-cli/issues/new) to request support for your
language, if you would be available for reviewing it as well.

```bash
LANG=ja_JP.UTF-8 dua i # then press '?' for the Japanese help screen
LANG=de_DE.UTF-8 dua i # German interface
LANG=ja_JP.UTF-8 dua i # Japanese interface
LANG=ko_KR.UTF-8 dua i # Korean interface
LANG=zh_CN.UTF-8 dua i # Simplified Chinese interface
```

### Flame graphs
Expand Down
19 changes: 11 additions & 8 deletions src/interactive/app/eventloop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl AppState {
snapshot_export: Option<(PathBuf, Option<i32>)>,
) -> Result<()> {
if self.read_only {
bail!("Snapshots are read-only");
bail!(self.language.ui_text().snapshots_read_only);
}
let bg_traversal = BackgroundTraversal::start(
traversal.root_index,
Expand Down Expand Up @@ -118,7 +118,7 @@ impl AppState {
if self.read_only {
let path = tree_view.path_of(self.navigation().view_root);
if path.as_os_str().is_empty() {
PathBuf::from("<snapshot>")
PathBuf::from(self.language.ui_text().snapshot_label)
} else {
path
}
Expand Down Expand Up @@ -173,15 +173,15 @@ impl AppState {

fn scan_parent(&mut self, tree: &mut TreeView<'_>) -> Result<()> {
if self.read_only {
self.message = Some("Snapshots are read-only".into());
self.message = Some(self.language.ui_text().snapshots_read_only.into());
return Ok(());
}
if self.scan.is_some() {
self.message = Some("Traversal already running".into());
self.message = Some(self.language.ui_text().traversal_running.into());
return Ok(());
}
let Some((parent, preexisting, wrap_root)) = self.parent_scan_target(tree) else {
self.message = Some("Top level reached".into());
self.message = Some(self.language.ui_text().top_level.into());
return Ok(());
};

Expand Down Expand Up @@ -477,6 +477,7 @@ impl AppState {
traversal,
&roots,
compression_level,
self.language,
)?;
}
self.scan = None;
Expand All @@ -486,6 +487,7 @@ impl AppState {
self.refresh_screen(window, traversal, display, terminal, config)?;
if is_finished {
let message = notification::scan_finished(
self.language,
self.stats.entries_traversed,
self.stats.total_bytes.unwrap_or_default(),
self.stats.elapsed.unwrap_or_else(|| self.stats.start.elapsed()),
Expand Down Expand Up @@ -750,12 +752,12 @@ impl AppState {
what: Refresh,
) -> anyhow::Result<()> {
if self.read_only {
self.message = Some("Snapshots are read-only".into());
self.message = Some(self.language.ui_text().snapshots_read_only.into());
return Ok(());
}
// If another traversal is already running do not do anything.
if self.scan.is_some() {
self.message = Some("Traversal already running".into());
self.message = Some(self.language.ui_text().traversal_running.into());
return Ok(());
}

Expand Down Expand Up @@ -890,9 +892,10 @@ impl AppState {
self.navigation.view_root,
glob_pattern,
case,
self.language,
) {
Ok(matches) if matches.is_empty() => {
self.message = Some("No match found".into());
self.message = Some(self.language.ui_text().no_match.into());
}
Ok(mut matches) => {
if let Some(glob_source) = &self.glob_navigation {
Expand Down
115 changes: 57 additions & 58 deletions src/interactive/app/handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ pub enum MarkEntryMode {
MarkForDeletion,
}

#[derive(Clone, Copy)]
enum AnnotationKind {
Cleanup,
Gitignored,
}

/// Aggregate outcome of an entire deletion or trash operation.
///
/// This combines the results for all selected entries and adds the operation's
Expand Down Expand Up @@ -83,12 +89,13 @@ impl AppState {
pub fn open_that(&mut self, tree_view: &TreeView<'_>) {
if let Some(idx) = self.navigation().selected {
let path = tree_view.path_of(idx);
let t = self.language.ui_text();
if self.read_only && !path.exists() {
self.message = Some(format!("Snapshot path is unavailable: {}", path.display()));
self.message = Some(format!("{}{}", t.snapshot_path_unavailable, path.display()));
return;
}
if let Err(err) = open::that(&path) {
self.message = Some(format!("Failed to open {}: {err}", path.display()));
self.message = Some(format!("{}{}: {err}", t.failed_to_open, path.display()));
}
}
}
Expand Down Expand Up @@ -127,11 +134,9 @@ impl AppState {
}
None => {
self.message = Some(if self.can_scan_parent(tree_view) {
format!(
"Top level reached. Press {scan_parent_key} to scan the parent directory"
)
self.language.top_level_with_scan(scan_parent_key)
} else {
"Top level reached".into()
self.language.ui_text().top_level.into()
});
}
}
Expand Down Expand Up @@ -171,7 +176,9 @@ impl AppState {
self.update_entry_annotations(tree_view);
self.reset_message();
}
None => self.message = Some("Entry is a file or an empty directory".into()),
None => {
self.message = Some(self.language.ui_text().entry_file_or_empty.into());
}
}
}
}
Expand Down Expand Up @@ -246,7 +253,12 @@ impl AppState {

pub fn toggle_gitignored_entries(&mut self, tree_view: &TreeView<'_>) {
if self.read_only {
self.message = Some("Gitignored entry detection is unavailable for snapshots".into());
self.message = Some(
self.language
.ui_text()
.gitignore_snapshot_unavailable
.into(),
);
return;
}
self.gitignored_entries = self.gitignored_entries.is_none().then(BTreeSet::new);
Expand Down Expand Up @@ -274,9 +286,9 @@ impl AppState {

pub fn reset_message(&mut self) {
if self.scan.is_some() {
self.message = Some("-> scanning <-".into());
self.message = Some(self.language.ui_text().scanning.into());
} else {
self.message = annotation_message(
self.message = self.language.annotation_message(
self.cleanup_candidates.as_ref().map_or(0, BTreeSet::len),
self.gitignored_entries.as_ref().map_or(0, BTreeSet::len),
);
Expand All @@ -286,7 +298,7 @@ impl AppState {
pub fn toggle_help_pane(&mut self, window: &mut MainWindow) {
self.focussed = match self.focussed {
Main | Mark | Glob => {
window.help = Some(HelpPane::with_locale_from_env());
window.help = Some(HelpPane::default());
Help
}
Help => {
Expand Down Expand Up @@ -332,12 +344,12 @@ impl AppState {
.and_then(|p| p.process_events(key, &config.keys));
window.mark = match res {
Some((pane, Some(_))) if self.read_only => {
self.message = Some("Snapshots are read-only".into());
self.message = Some(self.language.ui_text().snapshots_read_only.into());
Some(pane)
}
Some((pane, mode)) => match mode {
Some(MarkMode::Delete) => {
self.message = Some("Deleting items...".to_string());
self.message = Some(self.language.ui_text().deleting_items.into());
let start = Instant::now();
let mut entries_deleted = 0;
let mut bytes_deleted = 0;
Expand All @@ -350,7 +362,8 @@ impl AppState {
Ok(stats) => {
entries_deleted += stats.entries;
bytes_deleted += stats.bytes;
self.message = Some(format!("Deleted {entries_deleted} items..."));
self.message =
Some(self.language.deletion_progress(entries_deleted, false));
Ok(pane)
}
Err(stats) => {
Expand All @@ -363,7 +376,7 @@ impl AppState {
});
self.message = None;
self.notify_deletion_finished(
"Deletion",
self.language.ui_text().notification_deletion,
DeletionStats {
entries: entries_deleted,
bytes: bytes_deleted,
Expand All @@ -377,7 +390,7 @@ impl AppState {
}
#[cfg(feature = "trash-move")]
Some(MarkMode::Trash) => {
self.message = Some("Trashing items...".to_string());
self.message = Some(self.language.ui_text().trashing_items.into());
let start = Instant::now();
let mut entries_trashed = 0;
let mut bytes_trashed = 0;
Expand All @@ -394,7 +407,8 @@ impl AppState {
Ok(ed) => {
entries_trashed += ed;
bytes_trashed += entry_size;
self.message = Some(format!("Trashed {entries_trashed} items..."));
self.message =
Some(self.language.deletion_progress(entries_trashed, true));
Ok(pane)
}
Err(c) => {
Expand All @@ -405,7 +419,7 @@ impl AppState {
});
self.message = None;
self.notify_deletion_finished(
"Trash",
self.language.ui_text().notification_trash,
DeletionStats {
entries: entries_trashed,
bytes: bytes_trashed,
Expand Down Expand Up @@ -434,6 +448,7 @@ impl AppState {
config: &Config,
) {
let message = notification::deletion_finished(
self.language,
action,
stats.entries,
stats.bytes,
Expand Down Expand Up @@ -589,36 +604,34 @@ impl AppState {
match self.cleanup_candidates.clone() {
Some(cleanup_candidates) => self.mark_annotation_candidates(
cleanup_candidates,
"No cleanup candidates in view",
"Cleanup candidates are already marked",
"cleanup candidates",
AnnotationKind::Cleanup,
window,
tree_view,
),
None => self.message = Some("Cleanup candidate detection is disabled".into()),
None => {
self.message = Some(self.language.ui_text().cleanup_detection_disabled.into());
}
}
}

pub fn mark_gitignored_entries(&mut self, window: &mut MainWindow, tree_view: &TreeView<'_>) {
match self.gitignored_entries.clone() {
Some(gitignored_entries) => self.mark_annotation_candidates(
gitignored_entries,
"No gitignored entries in view",
"Gitignored entries are already marked",
"gitignored entries",
AnnotationKind::Gitignored,
window,
tree_view,
),
None => self.message = Some("Gitignored entry detection is disabled".into()),
None => {
self.message = Some(self.language.ui_text().gitignore_detection_disabled.into());
}
}
}

fn mark_annotation_candidates(
&mut self,
annotation_candidates: BTreeSet<TreeIndex>,
none_in_view_message: &str,
already_marked_message: &str,
marked_label: &str,
kind: AnnotationKind,
window: &mut MainWindow,
tree_view: &TreeView<'_>,
) {
Expand All @@ -639,13 +652,22 @@ impl AppState {
}

if candidates.is_empty() {
self.message = Some(if annotation_candidates.is_empty() {
none_in_view_message.into()
} else {
already_marked_message.into()
});
let t = self.language.ui_text();
self.message = Some(
match (kind, annotation_candidates.is_empty()) {
(AnnotationKind::Cleanup, true) => t.no_cleanup_candidates,
(AnnotationKind::Cleanup, false) => t.cleanup_candidates_already_marked,
(AnnotationKind::Gitignored, true) => t.no_gitignored_entries,
(AnnotationKind::Gitignored, false) => t.gitignored_entries_already_marked,
}
.into(),
);
} else {
self.message = Some(format!("Marked {} {marked_label}", candidates.len()));
self.message =
Some(self.language.marked_candidates(
candidates.len(),
matches!(kind, AnnotationKind::Gitignored),
));
}
}

Expand All @@ -672,29 +694,6 @@ impl AppState {
}
}

fn annotation_message(cleanup_count: usize, gitignored_count: usize) -> Option<String> {
match (cleanup_count, gitignored_count) {
(0, 0) => None,
(cleanup, 0) => {
let label = if cleanup == 1 {
"cleanup candidate"
} else {
"cleanup candidates"
};
Some(format!("{cleanup} {label}"))
}
(0, gitignored) => {
let label = if gitignored == 1 {
"gitignored entry"
} else {
"gitignored entries"
};
Some(format!("{gitignored} {label}"))
}
(cleanup, gitignored) => Some(format!("{cleanup} cleanup, {gitignored} gitignored")),
}
}

fn io_err_to_usize(err: io::Error) -> usize {
usize::from(err.kind() != io::ErrorKind::NotFound)
}
Expand Down
Loading
Loading