Read signature inputs from where CAPEv2 stores them now - #596
Merged
Merged
Conversation
CAPEv2 no longer fills results["static"] or results["virustotal"]. The PE, .NET, Office, PDF and Java details and file VirusTotal lookups are stored under results["target"]["file"] by file_extra_info, and URL tasks keep their WHOIS text and VirusTotal lookup under results["url"]. Signatures still reading the old keys never fire; abstracts.py itself carries a "not sure if static still exist" ToDo. Point the signatures in 23 files at the current locations: the .NET and Themida packers, PE version info and resource language, overlay, static_authenticode, bad_certs, static_pdf, static_java, mimics_icon, the Office macro, metadata, codepage, XLM, RTF object and DDE checks, whois_create, and antivirus_virustotal for both file and URL tasks. Remove static_rat_config. It read results["static"]["rat"], filled by the RAT decoders of the original Cuckoo, which nothing produces now; cape_extracted_config reports CAPE's own configuration extraction. Checked over 68 PE, MSI, Office and PDF samples, plus RTF, DDE and WHOIS inputs shaped like parse_office and parse_url output: every changed signature gives the same verdict and data as the original run against the old keys.
With guest_signers read from target.file, invalid_authenticode_signature runs again, and it fired on every PE the guest found unsigned: digisig reports "No signature found." and "file format cannot be verified" as errors as well, and the signature took any error for a bad signature. Over 28 reports from a production CAPEv2 it flagged 20 files, 15 of them unsigned. Skipping those two outcomes leaves the 5 whose signature WinVerifyTrust rejected (0x80096004, 0x80096010).
Collaborator
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAPEv2 no longer fills
results["static"]orresults["virustotal"]. The PE, .NET, Office, PDF and Java details and file VirusTotal lookups are stored underresults["target"]["file"]byfile_extra_info, and URL tasks keep their WHOIS text and VirusTotal lookup underresults["url"]. Signatures still reading the old keys never fire;abstracts.pyitself carries a "not sure if static still exist" ToDo.This points the signatures in 23 files at the current locations: the .NET and Themida packers, PE version info and resource language, overlay,
static_authenticode,bad_certs,static_pdf,static_java,mimics_icon, the Office macro, metadata, codepage, XLM, RTF object and DDE checks,whois_create, andantivirus_virustotalfor both file and URL tasks.It also removes
static_rat_config: it readresults["static"]["rat"], filled by the RAT decoders of the original Cuckoo, which nothing produces now;cape_extracted_configreports CAPE's own configuration extraction.Testing: over 68 PE, MSI, Office and PDF samples, plus RTF, DDE and WHOIS inputs shaped like
parse_officeandparse_urloutput, every changed signature gives the same verdict and data as the original code run against a report that still exposes the old keys.