fix(vcs): correct GitLab base URL - #979
Merged
Merged
Conversation
* We override the base URL in `VCS_PROVIDER_CONFIG_DICT`, where it is correctly configured on sandbox and prod. Until recently, this override was being passed on to the oauthclient and working perfectly. * However at some point recently this stopped working, and the oauthclient now uses the original base URL in `invenio.cfg` while ignoring the override value in the env var. * As a quick fix, I am changing the URL here. We are now using production GL on dev/sandbox/prod so it makes sense to do this.
zzacharo
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #966
We override the base URL in
VCS_PROVIDER_CONFIG_DICT, where it is correctly configured on sandbox and prod. Until recently, this override was being passed on to the oauthclient and working perfectly.However at some point recently this stopped working, and the oauthclient now uses the original base URL in
invenio.cfgwhile ignoring the override value in the env var.As a quick fix, I am changing the URL here. We are now using production GL on dev/sandbox/prod so it makes sense to do this.