Skip to content

Add parallelization to PMP_boolean_operation#9544

Open
LeoValque wants to merge 36 commits into
CGAL:mainfrom
LeoValque:PMP-bool_ops_parallellization
Open

Add parallelization to PMP_boolean_operation#9544
LeoValque wants to merge 36 commits into
CGAL:mainfrom
LeoValque:PMP-bool_ops_parallellization

Conversation

@LeoValque

Copy link
Copy Markdown
Contributor

Summary of Changes

Improve efficiency and add parallelization to functions PMP::corefine_and_compute_boolean_operations() (and all its variants).

Release Management

  • Affected package(s):PMP
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any): TODO
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: GF

afabri and others added 30 commits May 7, 2026 18:52
Comment thread AABB_tree/doc/AABB_tree/aabb_tree.txt
Comment thread AABB_tree/doc/AABB_tree/aabb_tree.txt
Comment thread AABB_tree/doc/AABB_tree/aabb_tree.txt
Comment thread AABB_tree/doc/AABB_tree/aabb_tree.txt
Comment thread AABB_tree/doc/AABB_tree/aabb_tree.txt

#include <CGAL/AABB_tree.h>
#include <CGAL/AABB_traits_3.h>
#include <CGAL/Polyhedron_3.h>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <CGAL/Polyhedron_3.h>

#include <CGAL/IO/polygon_soup_io.h>
#include <CGAL/boost/graph/generators.h>

#include <CGAL/Polygon_mesh_processing/transform.h>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those two includes needed?

class PatchDescription,
class VertexPointMap,
class VertexPointMapOut,
// class EdgeMarkMapOut,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup

put(vpm_out, new_v, get(vpm_tm, v));
output.set_halfedge(new_v, null_halfedge());
};
#ifdef CGAL_LINKED_WITH_TBB

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am niot sure that it is a good idea that we assume that we can just do things in parallel.

}


template <class EdgeToEdgeMap,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloriot do we care about class vs typename ?

@LeoValque LeoValque added Pkg::PMP Speed depends on another PR This pull-request should only be merged after other ones. labels Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends on another PR This pull-request should only be merged after other ones. Pkg::PMP Speed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants