Covert all uses of Submit Nodes to Groups - #20
mattriggle05 wants to merge 12 commits into
Conversation
9a195a9 to
344eb45
Compare
|
MUST be merged at the same time as CHTC/chtc-user-ui#71 |
CannonLock
left a comment
There was a problem hiding this comment.
@mattriggle05 Can you run through this and handle the TODOs.
I am pro deleting everything that isn't being used anymore as it is just fine checking git history/blame if I need to do some git archeology. Explicitly I would go through and delete the pieces that can get deleted here and remove the TODO comments.
| # TODO: Remove this — submit nodes replaced by SUBMIT_NODE groups | ||
| # from .submit_nodes import router as submit_nodes_router |
There was a problem hiding this comment.
Can you clean up the TODOs. LMK if there is a reason to push these of for another section of work.
There was a problem hiding this comment.
Doen and double checked, onyl remaining refernce to old submit nodes is int he old migrate.py
|
Due to changes of plan, submit nodes are staying, changes will be made in new branch TBA in issue #16 |
API side of issue #16