Firefly-2091 Handle VOTable Error Formats - #2021
Merged
Merged
Conversation
aventura121
force-pushed
the
FIREFLY-2091-invalid-table-xml
branch
from
September 23, 2026 19:56
18640f6 to
34d4e4a
Compare
aventura121
changed the title
aventura121
marked this pull request as ready for review
September 24, 2026 13:09
loitly
approved these changes
Sep 24, 2026
loitly
left a comment
loitly
left a comment
Contributor
There was a problem hiding this comment.
I tested the changes, and they worked as described. The added unit tests are great. I’ve included several comments for your review and implementation as you see fit.
aventura121
force-pushed
the
FIREFLY-2091-invalid-table-xml
branch
from
September 24, 2026 17:56
aca7dfa to
bb088e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2091: "UI Components: Table and chart display problem when the return data (xml format) is invalid"
This pull request also closes: Firefly-1665 "Modify VoTableReader to identify and handle error VOTables"
Description
We make changes to handle different VOTable representations of errors and the case where no table is found.
Unit Tests
We add unit tests with XML fixtures for unhandled formats and the no table case, etc.
Manual QA Testing
Build: https://firefly-2091-invalid-table-xml-2.irsakubedev.ipac.caltech.edu/firefly
We can manually validate the case from NED. It reports its error in a PARAM named QUERY_STATUS, but Firefly only looked for an INFO, so it missed the error and later failed with a SQL error. With the code changes, Firefly now reads the PARAM and shows NED's message.
(1) Use a NED url with a made-up object name. The XML can be viewed here. With the changes, we're able to show the NED error (i.e. the fix): test build link
This should show: "Cause: [GeneralFault] Service could not complete request; Failed to resolve input object name (6)".
(2) We can compare what happens if we load this url on irsacloud, to see the existing SQL error failure case (i.e. the bug): irsacloud link. This shows "Uncategorized SQL..."