Add regressions tests for the mod_dnsbl module in this repo, as we us… - #38
Merged
Merged
Conversation
…e mod_proxy_protocol to lie about the client's IP address.
Castaglia
commented
Aug 28, 2026
| } | ||
|
|
||
| static const char haproxy_v2_sig[12] = "\x0D\x0A\x0D\x0A\x00\x0D\x0A\x51\x55\x49\x54\x0A"; | ||
| static const char __attribute__ ((__nonstring__)) haproxy_v2_sig[12] = "\x0D\x0A\x0D\x0A\x00\x0D\x0A\x51\x55\x49\x54\x0A"; |
Owner
Author
There was a problem hiding this comment.
Quells a compiler warning about an unterminated string initializer.
Castaglia
commented
Aug 28, 2026
|
|
||
| if (pr_netaddr_cmp(session.c->local_addr, proxied_dst_addr) != 0 || | ||
| session.c->local_port != proxied_dst_port) { | ||
| session.c->local_port != (int) proxied_dst_port) { |
Owner
Author
There was a problem hiding this comment.
Quells compiler warning about comparing signed and unsigned ints.
Castaglia
commented
Aug 28, 2026
| session.c->remote_name = pr_netaddr_get_ipstr(session.c->remote_addr); | ||
| } | ||
|
|
||
| pr_netaddr_set_sess_addrs(); |
Owner
Author
There was a problem hiding this comment.
This actually resets the cached pointers for the session, for the remote IP/name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e mod_proxy_protocol to lie about the client's IP address.