Fix crash in Wear OS sync when Bluetooth is disabled - #3340
Merged
Merged
Conversation
We really need to handle Bluetooth better, but right now this will just spam users who have Bluetooth disabled
TheLastProject
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3338
We change the start order to first start the foreground service, and then kill it if our sanity checks fail. This prevents Android from killing our app using
ForegroundServiceDidNotStartInTimeException. It is a bit silly to start a service and then instantly close it, but it prevents users from getting into startup loops.TODO: See if we can auto-restart on Bluetooth state changes.