fix(frontend): preserve unhandled text directives - #3011
Open
morincl wants to merge 5 commits into
Open
Conversation
Restore literal directive syntax when remark-directive parses ordinary text and no plugin maps the node to HAST. Fixes Chainlit#1930. `remark-directive` parses colon-prefixed alphabetic text as a `textDirective`, but unhandled text directives lose their original source during conversion to HAST. This adds a default handler that preserves the source text while retaining the Markdown alert support introduced in Chainlit#1791.
morincl
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
August 7, 2026 10:25
dosubot
Bot
added
size:M
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
This PR is stale because it has been open for 14 days with no activity. |
github-actions
Bot
added
the
stale
Author
|
A little ping to keep this PR alive :) |
github-actions
Bot
removed
the
stale
Collaborator
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore literal directive syntax when remark-directive parses ordinary text and no plugin maps the node to HAST.
Background
Fixes #1930.
remark-directiveparses colon-prefixed alphabetic text as atextDirective, but unhandled text directives lose their original source during conversion to HAST. This adds a default handler that preserves the source text while retaining the Markdown alert support introduced in #1791.Summary by cubic
Preserves literal text when
remark-directiveparses colon-prefixed words astextDirective. Previously unhandled directives were dropped during conversion; now they render exactly as written, and Markdown alerts continue to work.textDirectivehandler inremarkRehypeOptionsthat emits the original source when no HAST mapping exists; wire it intoreact-markdown.Written for commit fbd1f82. Summary will update on new commits.