Client remove#169
Conversation
To work with extracted reccaster
|
What about putting reccaster in https://github.com/epics-modules instead? |
|
@tynanford raises a good question. I don't mind it being in the ChannelFinder organisation, but with the separation it ends up being a bit idiosyncratic... |
|
There are arguments for both and examples for both. If you were to search for |
We could do a mirror in one direction or the other? |
|
Like an automatically sync'ed fork? A soft link would be enough, but I don't think there are such simple solutions. |
Also link to the new home
Was only used for the client ci
|
|
I would personally support putting this under epics-modules (why don't we just have a singular epics org?!?). I think your theoretical question can be mitigated with just documentation @ralphlange:
|
|
IMO this MR depends on also a rename - I don't think this project should be called recsync if we now separate recCaster from recCeiver. I'd suggest calling this project just recCeiver and then creating a separate project called recsync-protocol (or similar) to capture the wire spec. |
Base, Modules, Extensions was the original split since always. Base: The Core stuff, under the responsibility of the Core Developers So the scope, people involved, teams, access, openness are pretty different. |
I was thinking more removing recceiver from here and keeping this repo as the recsync protocol. |
i.e. pull out server to recceiver-twisted. |
|
@anderslindho I could pull out server first? I kind of wanted to rush this so we can block any PRs on client. Then do other changes after. |
reccaster locationCan we keep it under ChannelFinder and have an automatically sync'd mirror/fork under epics-modules recsync repo backward compatiblityCreate a temporary git submodule client which points to ChannelFinder/reccaster. This is to support various build pipelines until every facility has a chance to port over. In the long term we can move this repo to being just the protocol description |
|
This works quite nicely... so we can easily setup and automatically updated fork un |
I don't like this. Its already broken because submodules aren't automatically pulled. Better to make a hard line. |
|
I agree with @jacomago. If we're moving this out, let's move it out. I also don't like a mirror tbh; I'm fine with it being under the ChannelFinder org since other things are, but a mirror feels weird to me. |
I am thinking that GH has pretty good support for this already by forming teams, but you mean this is annoying to work with @ralphlange? |
I don't like this name @jacomago. I otherwise agree with splitting it out, but IMO this product has claim on the name |
It did not when we moved EPICS Base to GitHub. EPICS-Modules has 67 repos, EPICS-Extensions has 35 repos, EPICS-Base has 25 repos. But I don't want to keep you from suggesting this at one of the meetings. Be prepared to be asked for a few important advantages... |
|
I'd use teams and topics. A naming convention might be nice but shouldn't be necessary. I think the value gained lies both in discoverability (I have never heard of epics-rip!) but even more-so in simplifying configuration (CI, secrets, actions). Plus maybe even semantics - as you say this would/should have been a singular org if there had been access to better tools and features, which nowadays do exist. But I concede I am going to much off topic now here in this thread. I'll bring this as my next controversial topic if I come to more meetings. ;) |
|
So I see many topics discussed here, but the main question for this pull request appears to be, accept this version or do a submodule approach. As mentioned I don't like the submodule approach:
I do think we should be speedy with merging this pull request though. We don't want new MRs to come to this project on the reccaster module (I know that's rare at the moment). |
ralphlange
left a comment
There was a problem hiding this comment.
This client-removal PR looks fine.
Otherwise, I am
- against doing a temporary
submodulething.
Either do a topical parent (e.g. for the complete stack) that uses submodules to fix the module versions in a common release or let things break and apologize. - against a sync'ed fork in
epics-modules.
a) the client was never there.
b) it would be the first module appearing in multiple epics-related orgs. I would like to see a stronger justification for introducing a new possibly maintenance-effort-producing custom.
|
I don't have a strong opinion on where this lives or whether to have a synced fork. So sticking with https://github.com/ChannelFinder/reccaster sounds good to me. I think we should announce this removal on tech-talk first just to give everyone a heads up. It will break people's build scripts and CI |
|
I agree that we should announce a time line. How about we say we will merge this on 25th. |
|
How/why would it break CI? |
|
I meant peoples local CI runners/scripts which might do git clone and then |
|
Ah. What about replacing the client with a Makefile that prints an apology and the new URL? |
|
There is also all the packing projects ( like recsync-env ) which might have to be redone to keep them working. Based on the theme of this discussion it seems like the print out message would be more an condescending comment rather than an apology :) Anyway, |
|
If I were concerned, I would complain about less than two weeks notice, which seems short for a planned intervention. But I'm not, so I won't. |



Moved to https://github.com/ChannelFinder/reccaster
Requires ChannelFinder/reccaster#1 to be merged