push: Verify site CA on registration - #22
Merged
Merged
Conversation
relrod
requested review from
Copilot and
racicLuka
and removed request for
Copilot
July 28, 2026 09:39
metrics-cache previously accepted any server certificate (pure Trust On First Use) when registering to the push-agent receiver. This meant the one-time token was vulnerable to MITM who could register as the cluster. The registration/bootstrap now verifies the receiver against a site CA certificate supplied via push.siteCaCertificate before sending the token. This only affects the registration step; the receiver then returns the site CA again which is stored for doing actual pushes. There is an explicit opt-out of verification via push.insecureSkipSiteCAVerification, which defaults to false but allows for the dev environment to spin up without someone having to pass in a certificate (only a token).
racicLuka
reviewed
Jul 28, 2026
racicLuka
approved these changes
Jul 28, 2026
racicLuka
left a comment
racicLuka
left a comment
There was a problem hiding this comment.
LGTM!
With this, history has been written!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metrics-cache previously accepted any server certificate (pure Trust On First Use) when registering to the push-agent receiver. This meant the one-time token was vulnerable to MITM who could register as the cluster.
The registration/bootstrap now verifies the receiver against a site CA certificate supplied via push.siteCaCertificate before sending the token.
This only affects the registration step; the receiver then returns the site CA again which is stored for doing actual pushes.
There is an explicit opt-out of verification via
push.insecureSkipSiteCAVerification, which defaults to false but allows for the dev environment to spin up without someone having to pass in a certificate (only a token).