Include podman-host assets in the deployable bundle - #24
Open
ChrisonSimtian wants to merge 1 commit into
Open
ChrisonSimtian wants to merge 1 commit into
ChrisonSimtian wants to merge 1 commit into
Conversation
BundlePaths() is hand-maintained and silently omits any asset directory not listed, and the previous commit added podman-host/quadlets/ without touching it. This one was especially easy to miss: the *.lxc.yaml glob already picks up podman-host.lxc.yaml, so a bundle would carry the SHAPE but not its quadlets. A deploy from the release tag would create CT 3006, render zero units, and report success — the exact silent-omission failure the comment in BundlePaths() warns about. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ChrisonSimtian
added
bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BundlePaths()inbuild/Build.csis hand-maintained and silently omits any asset directory not listed incandidates. #23 addedpodman-host/quadlets/without touching it.This one is especially easy to miss, and worth spelling out: the
*.lxc.yamlglob already picks uppodman-host.lxc.yaml. So a bundle carries the shape but not its quadlets — meaning a deploy from the release tag would create CT 3006, render zero units, and report success. That's precisely the failure mode the comment inBundlePaths()warns about:Nothing would have failed to tell you.
Change
var candidates = new[] { "stack.yaml", "shell-assets", + "podman-host", };With a comment recording why this specific omission was dangerous rather than just that it was missing.
Testing
./build.sh Bundleis the check. Note the validator is linux-x64 only, so on macOS./build.shfails atRestoreValidator— CI is the real gate here.