fix(collectors): ignore transient target errors when subscribing to service workers - #2888
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2026
OrKoN
force-pushed
the
fix/sw-collector-flake
branch
from
October 1, 2026 13:01
954bee1 to
eb531f1
Compare
OrKoN
force-pushed
the
fix/sw-collector-flake
branch
from
October 1, 2026 13:08
eb531f1 to
9be91b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI flakiness in
tests/McpContext.test.ts(unhandledRejection: ProtocolError: Protocol error (Target.attachToTarget): No target with given id found).No target with given id foundandNo session with given idinServiceWorkerConsoleCollector, track subscribers before awaitingsubscribe(), and clean up if destroyed/disposed mid-subscription.McpContextinside atry ... finallyblock inwithMcpContextso target listeners do not outlive the test callback.tests/collectors/ServiceWorkerCollector.test.ts.