Skip to content

docs(pr-test-sync): diagnostic helpers, rate-limit budget, early readonly merge, same-step failures - #133

Merged
saqibmanan merged 4 commits into
mainfrom
docs/pr-test-sync-provider-smoke-lessons
Sep 25, 2026
Merged

saqibmanan merged 4 commits into
mainfrom
docs/pr-test-sync-provider-smoke-lessons

Conversation

@saqibmanan

Copy link
Copy Markdown
Contributor

Updates .claude/skills/pr-test-sync/SKILL.md with lessons from fixing provider smoke (#128). One commit per section:

  • Reuse the diagnostic helpers; never hardcode admin-managed taxonomy. Adds a table of wait_for_option, click_until, sector_name, backend_enum_labels and save_failure_artifacts, and what each one prevents. Hardcoding the sector "Budgets" put CI provider-smoke red on every PR after the 2026-09-24 dev refresh.
  • Budget browser runs against 1000 POST/hour. A 429 doesn't skip a browser test; the test hangs after login and dies as a blank timeout. About three full provider runs from one machine spent the hour, twice. Explains the new "backend rate limit" report section.
  • Readonly tests merged before the feature reached prod. What to tell the user, and why any DataSpaceBackend main merge (including dependabot) becomes a rollback risk until the feature ships. This happened with test: embedded use case dashboards (DataSpaceFrontend #476) #122 / DataSpaceFrontend#476.
  • Gotchas:

sector_name, wait_for_option and the 429 section come from #128. The skill says to check that #128 is in the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant