docs: label the scheduled checks as Keycloak tests - #27
Merged
Merged
Conversation
The badge read "auth tests" and the workflow was named "Auth tests", which does not say what is being tested. Everything in this repository is auth; the distinction that matters is that these are the Keycloak page and issuer checks, as opposed to the build (ci) or the deployment. Renames both the badge label and the workflow's display name to "Keycloak tests", so the badge, the Actions tab and the run history all use the same term. The file keeps its name to preserve the workflow's run history - GitHub treats a renamed workflow file as a new workflow and the badge would reset to "no status". Matching badge added to CivicDataSpace-test, which is where the tests actually live, so the same term appears in both repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The badge read
auth testsand the workflow was named "Auth tests" — neither says what is being tested. Everything in this repository is auth; the useful distinction is that these are the Keycloak page and issuer checks, as opposed to the build (ci) or the deployment (deploy).Change
auth testskeycloak testsSo the badge, the Actions tab and the run history all use the same term.
Verified rendering:
keycloak tests: passingThe file keeps its name
auth-tests.ymlis unchanged on disk. GitHub treats a renamed workflow file as a new workflow — the run history would be orphaned and the badge would reset tono status. Only the display name changes, which is what the badge reads.Matching badge in the test repo
CivicDataSpace-test#31 adds a
keycloak testsbadge pointing at this same workflow, since that is where the tests actually live but they have no standalone run history of their own (a reusable workflow's runs are recorded against the caller). Same term in both repositories.