Fix/login UI alignment - #4
Closed
UdayRajSahai2 wants to merge 3 commits into
Closed
UdayRajSahai2 wants to merge 3 commits into
UdayRajSahai2 wants to merge 3 commits into
Conversation
The lockfile was left inconsistent when @tabler/icons-react was added (it looks to have been installed with yarn), so `npm ci` fails outright: "Missing: @tabler/icons-react from lock file" plus a dozen version mismatches. Regenerated with npm so reproducible installs work in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We kept Keycloakify’s default login and register. We only edited copies of those pages so Civic styling, brand social icons, and Tabler error/eye icons actually show in Keycloak.
Changes
KcPage.tsx
Problem: Keycloak still loaded the untouched default login, so our login edits never appeared.
Fix: Point login.ftl at our edited copy of the default login. Point register at our edited copy of the default profile fields.
pages/Login.tsx
Problem: Same default login, but social buttons, password eye, and field errors looked wrong.
Fix: Keep the default form. Change social text to “Continue With …”, swap in brand icons, and use our eye + error icons.
CustomTemplate.tsx
Problem: Alert banners used emoji, and Keycloak sometimes drew a second icon on top.
Fix: Same layout. Replace warning/error/info emoji with Tabler icons.
SocialProviderIcon.tsx
Problem: Default login used Font Awesome IdP icons, which were missing or generic.
Fix: Add SVG logos (Google, Microsoft, GitHub, etc.) and pick one from the provider id.
PasswordWrapper.tsx
Problem: Default show/hide password control used font/CSS icons, so the eye looked broken.
Fix: Same toggle behavior. Draw Tabler eye / eye-off instead.
FieldErrorIcon.tsx
Problem: Field errors used a CSS ⚠ emoji, and not every error used it.
Fix: One small Tabler alert icon reused on login and register errors.
UserProfileFormFields.tsx
Problem: Register still used Keycloakify’s untouched fields, so login icons did not appear there.
Fix: Copy the default profile-fields component. Add FieldErrorIcon and PasswordWrapper only.
civic-theme.css
Problem: Default Keycloak/PatternFly CSS overrode ours (social buttons, eye, alerts, checkboxes, footer).
Fix: Update CSS so those pieces match the new markup and Civic layout.
package.json + lockfiles
Problem: Tabler icons were imported but not listed as a dependency.
Fix: Add @tabler/icons-react and update lockfiles