fix(ci): fail the run when any suite has failing tests - #15
Merged
Merged
Conversation
Every pytest step is continue-on-error, so shards went green with 1-7 failed tests. Test Summary now fails the run from the real JSON counts. Refs #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12.
Why
Every suite's pytest step runs with
continue-on-error: trueso all reports get produced. That also made each job green regardless of results. The most recent E2E run (PR #13, 2026-09-28) had shard 2 = 1 failed and shard 3 = 7 failed, both ✅.Change
scripts/suite_summary.pyreturns 1 when any suite has failed/errored tests (missing report or all-skipped still returns 0 — path-filtered suites don't produce one).TESTS_FAILEDand a final step fails the run, after the table and combined report are written.Heads-up
Current E2E has 8 real failures on dev, so the first E2E run after this merges will go red. That's the point — those were already failing, just hidden.
Verified
Script against fixture reports: failing → 1, passing → 0, missing → 0. Workflow YAML parses.