Skip to content

New. Security. Lost-password interface is under rate limit. #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Glomberg wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

New. Security. Lost-password interface is under rate limit. #755

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca80c54
Upb. BFP. Lost password requests protection implemented.
Glomberg Sep 29, 2026
50f6d52
Fix. Security. Lost password requests protection fix - hook changed.
Glomberg Sep 29, 2026
4e1b3cc
Dev. Code. Code style fixed.
Glomberg Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion inc/spbc-auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
die('Not allowed!');
}

add_filter('authenticate', 'spbc_authenticate', 20, 2); // Hooks for authentificate
add_filter('authenticate', 'spbc_authenticate', 20, 2); // Hooks for authenticate
add_action('lostpassword_post', 'spbc_lostpassword_rate_limit', 20, 2); // Hooks for lost password request checking

// Hook for token-based logins (plugins like "Temporary Login Without Password")
add_action('set_logged_in_cookie', 'spbc_detect_token_login', 10, 6);
Expand Down Expand Up @@ -266,6 +267,30 @@ function spbc_authenticate($user, $username)
return $user;
}

function spbc_lostpassword_rate_limit($error)
{
global $spbc;
$limit = !empty($spbc->settings['bfp__allowed_wrong_auths'])
? (int) $spbc->settings['bfp__allowed_wrong_auths']
: 5;
$period = !empty($spbc->settings['bfp__block_period__5_fails'])
? (int) $spbc->settings['bfp__block_period__5_fails']
: 3600;
$config = new RateLimiterConfig('lostpassword_rate_limit', $limit, $period);
$rate_limiter = new SpbcRateLimiter($config);
$rate_limiter_check = $rate_limiter->checkPassed();
if ( ! $rate_limiter_check ) {
$limit_message = esc_html__('Current route access denied. (Security by CleanTalk)', 'security-malware-firewall');
add_filter('lostpassword_errors', function ($_errors, $_user) use ($limit_message) {
return new WP_Error(403, $limit_message);
}, 20, 2);
if (function_exists('wc_add_notice')) {
wp_die($limit_message, '', ['response' => 403]);
}
}
return $error;
}

/**
* Detecting new device
*
Expand Down
Loading