Skip to content

Upd. Firewall. Emergency bypass logic updated to token-via-email model. https://app.doboard.com/1/task/55234 - #897

Merged
alexandergull merged 1 commit into
devfrom
sfw_bypass.ag
Sep 29, 2026
Merged

alexandergull merged 1 commit into
devfrom
sfw_bypass.ag

Conversation

@alexandergull

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.35897% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.83%. Comparing base (096bee4) to head (22e9106).

Files with missing lines Patch % Lines
lib/Cleantalk/ApbctWP/Firewall/FirewallBypass.php 80.55% 21 Missing ⚠️
lib/Cleantalk/ApbctWP/RemoteCalls.php 0.00% 6 Missing ⚠️
cleantalk.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #897      +/-   ##
============================================
+ Coverage     30.62%   30.83%   +0.20%     
- Complexity     6651     6691      +40     
============================================
  Files           292      293       +1     
  Lines         26507    26624     +117     
============================================
+ Hits           8119     8209      +90     
- Misses        18388    18415      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Copilot review overview

🟡 Changes recommended

Unresolved PHP 5.6 compatibility and token lifecycle issues block approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity · 3 Medium severity

Open (5)
What changed in this PR

Adds an email-based, one-time emergency firewall bypass using browser tokens and cookies.

Changes:

  • Registers a rate-limited remote call and cooldown state.
  • Implements token generation, email delivery, storage, and validation.
  • Integrates bypass checks into firewall processing and updates URL escaping documentation.
File Summary
lib/​Cleantalk/​ApbctWP/​State.php Adds remote-call cooldown state.
lib/​Cleantalk/​ApbctWP/​RemoteCalls.php Registers the bypass-email remote action.
lib/​Cleantalk/​ApbctWP/​Firewall/​FirewallBypass.php Implements the token and cookie bypass flow.
lib/​Cleantalk/​ApbctWP/​Escape.php Updates return documentation.
cleantalk.php Integrates bypass checks into firewall processing.
Files excluded by content exclusion policy (4)
  • tests/ApbctWP/FindSpam/ListTable/TestComments.php
  • tests/ApbctWP/FindSpam/ListTable/TestUsers.php
  • tests/ApbctWP/FindSpam/ListTable/TestWcSpamOrdersListTable.php
  • tests/ApbctWP/Firewall/FirewallBypassTest.php

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/Cleantalk/ApbctWP/Firewall/FirewallBypass.php
Comment thread lib/Cleantalk/ApbctWP/RemoteCalls.php
Comment thread lib/Cleantalk/ApbctWP/Firewall/FirewallBypass.php
Comment thread lib/Cleantalk/ApbctWP/Firewall/FirewallBypass.php
Comment thread lib/Cleantalk/ApbctWP/Firewall/FirewallBypass.php Outdated
@alexandergull
alexandergull merged commit f03524c into dev Sep 29, 2026
10 checks passed
@alexandergull
alexandergull deleted the sfw_bypass.ag branch September 29, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants