Skip to content

Upd. Contacts encoder. Short codes functionality optimized. - #900

Open
Glomberg wants to merge 5 commits into
devfrom
Upd-Contacts-encoder-Short-codes-functionality-optimized-VI
Open

Glomberg wants to merge 5 commits into
devfrom
Upd-Contacts-encoder-Short-codes-functionality-optimized-VI

Conversation

@Glomberg

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.00%. Comparing base (b6945e5) to head (4b4909b).

Files with missing lines Patch % Lines
...actsEncoder/Shortcodes/ExcludedEncodeContentSC.php 9.09% 10 Missing ⚠️

❌ Your patch check has failed because the patch coverage (9.09%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #900      +/-   ##
============================================
- Coverage     32.03%   32.00%   -0.04%     
+ Complexity     6781     6774       -7     
============================================
  Files           292      292              
  Lines         26775    26756      -19     
============================================
- Hits           8578     8563      -15     
+ Misses        18197    18193       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Removing cache priming causes some title filters to expose unprocessed shortcodes.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Optimizes shortcode title handling by removing eager raw-title cache priming.

Changes:

  • Removes the initialization-time database query.
  • Documents lazy title-cache lookup and population.
File Description
ShortCodesService.php Removes eager cache priming registration.
ExcludedEncodeContentSC.php Removes priming implementation and clarifies lazy caching.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/Cleantalk/ApbctWP/ContactsEncoder/Shortcodes/ExcludedEncodeContentSC.php Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The lazy lookup introduces an N+1 SQL query pattern for commonly rendered post titles.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (2)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants