Skip to content

allow attribute based self-colocation of promotable roles #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenningerk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

allow attribute based self-colocation of promotable roles #4165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bca3a95
Test: scheduler: check for self-colocation of promotable role with at…
wenningerk Aug 17, 2026
e9c453c
Fix: scheduler: allow self-colocation of promotable role with attribute
wenningerk Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cts/cts-scheduler.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,9 @@ TESTS = [
SchedulerTest("no-promote-on-unrunnable-guest", "Don't select bundle instance for promotion when container can't run"),
SchedulerTest("leftover-pending-monitor", "Prevent a leftover pending monitor from causing unexpected stop of other instances"),
SchedulerTest("promotable-colocation-with-node-attribute", "Promote dependent clone on nodes belonging to a site that has a primary clone promoted"),
SchedulerTest("promotable-self-colocation-with-node-attribute", "Group promotions on a single site via self-colocation with node attribute"),
SchedulerTest("promotable-self-colocation-with-node-attribute-2", "Group promotions on siteB (not siteA) via self-colocation with node attribute"),
SchedulerTest("promotable-self-colocation-with-node-attribute-3", "Correct wrong-site promotions via self-colocation with node attribute"),
]),
SchedulerTestGroup([
SchedulerTest("history-1", "Correctly parse stateful-1 resource state"),
Expand Down
16 changes: 16 additions & 0 deletions cts/scheduler/dot/promotable-self-colocation-with-node-attribute-2.dot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
digraph "g" {
"site-clone_promote_0" -> "site-rsc_promote_0 node3" [ style = bold]
"site-clone_promote_0" -> "site-rsc_promote_0 node4" [ style = bold]
"site-clone_promote_0" [ style=bold color="green" fontcolor="orange"]
"site-clone_promoted_0" [ style=bold color="green" fontcolor="orange"]
"site-rsc_monitor_10000 node3" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_10000 node4" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_11000 node1" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_11000 node2" [ style=bold color="green" fontcolor="black"]
"site-rsc_promote_0 node3" -> "site-clone_promoted_0" [ style = bold]
"site-rsc_promote_0 node3" -> "site-rsc_monitor_10000 node3" [ style = bold]
"site-rsc_promote_0 node3" [ style=bold color="green" fontcolor="black"]
"site-rsc_promote_0 node4" -> "site-clone_promoted_0" [ style = bold]
"site-rsc_promote_0 node4" -> "site-rsc_monitor_10000 node4" [ style = bold]
"site-rsc_promote_0 node4" [ style=bold color="green" fontcolor="black"]
}
28 changes: 28 additions & 0 deletions cts/scheduler/dot/promotable-self-colocation-with-node-attribute-3.dot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
digraph "g" {
"site-clone_demote_0" -> "site-clone_demoted_0" [ style = bold]
"site-clone_demote_0" -> "site-rsc_demote_0 node3" [ style = bold]
"site-clone_demote_0" -> "site-rsc_demote_0 node4" [ style = bold]
"site-clone_demote_0" [ style=bold color="green" fontcolor="orange"]
"site-clone_demoted_0" -> "site-clone_promote_0" [ style = bold]
"site-clone_demoted_0" [ style=bold color="green" fontcolor="orange"]
"site-clone_promote_0" -> "site-rsc_promote_0 node1" [ style = bold]
"site-clone_promote_0" -> "site-rsc_promote_0 node2" [ style = bold]
"site-clone_promote_0" [ style=bold color="green" fontcolor="orange"]
"site-clone_promoted_0" [ style=bold color="green" fontcolor="orange"]
"site-rsc_demote_0 node3" -> "site-clone_demoted_0" [ style = bold]
"site-rsc_demote_0 node3" -> "site-rsc_monitor_11000 node3" [ style = bold]
"site-rsc_demote_0 node3" [ style=bold color="green" fontcolor="black"]
"site-rsc_demote_0 node4" -> "site-clone_demoted_0" [ style = bold]
"site-rsc_demote_0 node4" -> "site-rsc_monitor_11000 node4" [ style = bold]
"site-rsc_demote_0 node4" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_10000 node1" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_10000 node2" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_11000 node3" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_11000 node4" [ style=bold color="green" fontcolor="black"]
"site-rsc_promote_0 node1" -> "site-clone_promoted_0" [ style = bold]
"site-rsc_promote_0 node1" -> "site-rsc_monitor_10000 node1" [ style = bold]
"site-rsc_promote_0 node1" [ style=bold color="green" fontcolor="black"]
"site-rsc_promote_0 node2" -> "site-clone_promoted_0" [ style = bold]
"site-rsc_promote_0 node2" -> "site-rsc_monitor_10000 node2" [ style = bold]
"site-rsc_promote_0 node2" [ style=bold color="green" fontcolor="black"]
}
16 changes: 16 additions & 0 deletions cts/scheduler/dot/promotable-self-colocation-with-node-attribute.dot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
digraph "g" {
"site-clone_promote_0" -> "site-rsc_promote_0 node1" [ style = bold]
"site-clone_promote_0" -> "site-rsc_promote_0 node2" [ style = bold]
"site-clone_promote_0" [ style=bold color="green" fontcolor="orange"]
"site-clone_promoted_0" [ style=bold color="green" fontcolor="orange"]
"site-rsc_monitor_10000 node1" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_10000 node2" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_11000 node3" [ style=bold color="green" fontcolor="black"]
"site-rsc_monitor_11000 node4" [ style=bold color="green" fontcolor="black"]
"site-rsc_promote_0 node1" -> "site-clone_promoted_0" [ style = bold]
"site-rsc_promote_0 node1" -> "site-rsc_monitor_10000 node1" [ style = bold]
"site-rsc_promote_0 node1" [ style=bold color="green" fontcolor="black"]
"site-rsc_promote_0 node2" -> "site-clone_promoted_0" [ style = bold]
"site-rsc_promote_0 node2" -> "site-rsc_monitor_10000 node2" [ style = bold]
"site-rsc_promote_0 node2" [ style=bold color="green" fontcolor="black"]
}
95 changes: 95 additions & 0 deletions cts/scheduler/exp/promotable-self-colocation-with-node-attribute-2.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
<transition_graph cluster-delay="60s" fencing-timeout="60s" failed-stop-offset="INFINITY" failed-start-offset="INFINITY" transition_id="1">
<synapse id="0">
<action_set>
<rsc_op id="3" operation="monitor" operation_key="site-rsc_monitor_11000" internal_operation_key="site-rsc:0_monitor_11000" on_node="node1" on_node_uuid="node1">
<primitive id="site-rsc" long-id="site-rsc:0" class="ocf" provider="pacemaker" type="Stateful"/>
<attributes CRM_meta_clone="0" CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_interval="11000" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_name="monitor" CRM_meta_notify="false" CRM_meta_on_node="node1" CRM_meta_on_node_uuid="node1" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_role="Unpromoted" CRM_meta_timeout="20000" />
</rsc_op>
</action_set>
<inputs/>
</synapse>
<synapse id="1">
<action_set>
<rsc_op id="6" operation="monitor" operation_key="site-rsc_monitor_11000" internal_operation_key="site-rsc:1_monitor_11000" on_node="node2" on_node_uuid="node2">
<primitive id="site-rsc" long-id="site-rsc:1" class="ocf" provider="pacemaker" type="Stateful"/>
<attributes CRM_meta_clone="1" CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_interval="11000" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_name="monitor" CRM_meta_notify="false" CRM_meta_on_node="node2" CRM_meta_on_node_uuid="node2" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_role="Unpromoted" CRM_meta_timeout="20000" />
</rsc_op>
</action_set>
<inputs/>
</synapse>
<synapse id="2">
<action_set>
<rsc_op id="10" operation="monitor" operation_key="site-rsc_monitor_10000" internal_operation_key="site-rsc:2_monitor_10000" on_node="node3" on_node_uuid="node3">
<primitive id="site-rsc" long-id="site-rsc:2" class="ocf" provider="pacemaker" type="Stateful"/>
<attributes CRM_meta_clone="2" CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_interval="10000" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_name="monitor" CRM_meta_notify="false" CRM_meta_on_node="node3" CRM_meta_on_node_uuid="node3" CRM_meta_op_target_rc="8" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_role="Promoted" CRM_meta_timeout="20000" />
</rsc_op>
</action_set>
<inputs>
<trigger>
<rsc_op id="9" operation="promote" operation_key="site-rsc_promote_0" internal_operation_key="site-rsc:2_promote_0" on_node="node3" on_node_uuid="node3"/>
</trigger>
</inputs>
</synapse>
<synapse id="3">
<action_set>
<rsc_op id="9" operation="promote" operation_key="site-rsc_promote_0" internal_operation_key="site-rsc:2_promote_0" on_node="node3" on_node_uuid="node3">
<primitive id="site-rsc" long-id="site-rsc:2" class="ocf" provider="pacemaker" type="Stateful"/>
<attributes CRM_meta_clone="2" CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_notify="false" CRM_meta_on_node="node3" CRM_meta_on_node_uuid="node3" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_timeout="20000" />
</rsc_op>
</action_set>
<inputs>
<trigger>
<pseudo_event id="19" operation="promote" operation_key="site-clone_promote_0"/>
</trigger>
</inputs>
</synapse>
<synapse id="4">
<action_set>
<rsc_op id="14" operation="monitor" operation_key="site-rsc_monitor_10000" internal_operation_key="site-rsc:3_monitor_10000" on_node="node4" on_node_uuid="node4">
<primitive id="site-rsc" long-id="site-rsc:3" class="ocf" provider="pacemaker" type="Stateful"/>
<attributes CRM_meta_clone="3" CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_interval="10000" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_name="monitor" CRM_meta_notify="false" CRM_meta_on_node="node4" CRM_meta_on_node_uuid="node4" CRM_meta_op_target_rc="8" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_role="Promoted" CRM_meta_timeout="20000" />
</rsc_op>
</action_set>
<inputs>
<trigger>
<rsc_op id="13" operation="promote" operation_key="site-rsc_promote_0" internal_operation_key="site-rsc:3_promote_0" on_node="node4" on_node_uuid="node4"/>
</trigger>
</inputs>
</synapse>
<synapse id="5">
<action_set>
<rsc_op id="13" operation="promote" operation_key="site-rsc_promote_0" internal_operation_key="site-rsc:3_promote_0" on_node="node4" on_node_uuid="node4">
<primitive id="site-rsc" long-id="site-rsc:3" class="ocf" provider="pacemaker" type="Stateful"/>
<attributes CRM_meta_clone="3" CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_notify="false" CRM_meta_on_node="node4" CRM_meta_on_node_uuid="node4" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_timeout="20000" />
</rsc_op>
</action_set>
<inputs>
<trigger>
<pseudo_event id="19" operation="promote" operation_key="site-clone_promote_0"/>
</trigger>
</inputs>
</synapse>
<synapse id="6" priority="1000000">
<action_set>
<pseudo_event id="20" operation="promoted" operation_key="site-clone_promoted_0">
<attributes CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_notify="false" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_timeout="20000" />
</pseudo_event>
</action_set>
<inputs>
<trigger>
<rsc_op id="9" operation="promote" operation_key="site-rsc_promote_0" internal_operation_key="site-rsc:2_promote_0" on_node="node3" on_node_uuid="node3"/>
</trigger>
<trigger>
<rsc_op id="13" operation="promote" operation_key="site-rsc_promote_0" internal_operation_key="site-rsc:3_promote_0" on_node="node4" on_node_uuid="node4"/>
</trigger>
</inputs>
</synapse>
<synapse id="7">
<action_set>
<pseudo_event id="19" operation="promote" operation_key="site-clone_promote_0">
<attributes CRM_meta_clone_max="4" CRM_meta_clone_node_max="1" CRM_meta_globally_unique="false" CRM_meta_master_max="2" CRM_meta_master_node_max="1" CRM_meta_notify="false" CRM_meta_promoted_max="2" CRM_meta_promoted_node_max="1" CRM_meta_timeout="20000" />
</pseudo_event>
</action_set>
<inputs/>
</synapse>
</transition_graph>
Loading