Clean up main loop child and timer code, and deprecate their public API - #4167

Open

nrwahl2 wants to merge 70 commits into

ClusterLabs:mainfrom

nrwahl2:nrwahl2-mainloop_first

Commits on Aug 15, 2026

Refactor: libcrmcommon: Use bool for crm_trigger_t:running
nrwahl2
committed
ae9a754
Refactor: libcrmcommon: Use bool for crm_trigger_t:trigger
nrwahl2
committed
e880914
Refactor: libcrmcommon: Best practices for child_free()
nrwahl2
committed
624f79b
Refactor: libcrmcommon: Use bool for mainloop_child_t:timeout
nrwahl2
committed
cf1b668
Refactor: libcrmcommon: Best practices for mainloop_child_add_with_flags
nrwahl2
committed
67590c3
Refactor: libcrmcommon: Best practices for child_signal_init()
nrwahl2
committed
ef61e5c
Doc: libcrmcommon: Document struct mainloop_child_s
nrwahl2
committed
8486d01
Refactor: libcrmcommon: Rename mainloop_child_t:timerid to timer_id
nrwahl2
committed
bbf7369
Refactor: libcrmcommon: Rename mainloop_child_t:timeout to timed_out
nrwahl2
committed
c64f173
Refactor: libcrmcommon: Rename mainloop_child_t:privatedata to user_data
nrwahl2
committed
be572ab
Refactor: libcrmcommon: Replace mainloop_child_t:flags with kill_group
nrwahl2
committed
b5b3e49
Refactor: pacemakerd: Drop mainloop_child_name() internally
nrwahl2
committed
09e3fc5
Refactor: libcrmservice: Drop mainloop_child_timeout() internally
nrwahl2
committed
7ff8c3f
Refactor: various: Drop mainloop_child_userdata() internally
nrwahl2
committed
937f6e3
Refactor: libcrmservice: Drop mainloop_clear_child_userdata() internally
nrwahl2
committed
d7e043d
Refactor: libcrmcommon: New compare_children_by_pid()
nrwahl2
committed
fb1e807
Refactor: libcrmcommon: Use g_list_delete_link() in mainloop_child_kill
nrwahl2
committed
f83391b
Doc: libcrmcommon: Add Doxygen for mainloop_child_kill()
nrwahl2
committed
5a105f3
Refactor: libcrmcommon: Best practices in child_timeout_callback()
nrwahl2
committed
26393f7
Refactor: libcrmcommon: Drop five-second hung child check
nrwahl2
committed
2c952da
Refactor: libcrmcommon: Always set timed_out in child_timeout_callback()
nrwahl2
committed
04b1024
Refactor: libcrmcommon: Clean up child_kill_helper()
nrwahl2
committed
786738b
Refactor: libcrmcommon: Clean up child_death_dispatch()
nrwahl2
committed
a5bbf75
Refactor: libcrmcommon: Move duplicated functionality to child_waitpid()
nrwahl2
committed
f9037f4
Refactor: libcrmcommon: CRM_CHECK() else case in child_waitpid()
nrwahl2
committed
589a217
Refactor: libcrmcommon: child_waitpid() takes a bool argument
nrwahl2
committed
8f04db4
Log: libcrmcommon: child_waitpid() logs more specific messages
nrwahl2
committed
767f966
Low: libcrmcommon: Fix core dumped logic in child_waitpid()
nrwahl2
committed
b6221c6
Low: libcrmcommon: Don't set signo/exitcode for nonpositive child->pid
nrwahl2
committed
8985333
Doc: libcrmcommon: Add Doxygen to child_waitpid()
nrwahl2
committed
273ab09
Low: libcrmcommon: Fix child_waitpid() return values
nrwahl2
committed
40fb285
Low: libcrmcommon: Don't set signo to SIGCHLD for waitpid() ECHILD
nrwahl2
committed
7657ae3
Refactor: libcrmcommon: New pcmk__main_loop_child_create()
nrwahl2
committed
437c07b
Refactor: libcrmservice: Use bool variable in services_action_cancel()
nrwahl2
committed
6f38b70
Refactor: libcrmcommon: New pcmk__main_loop_child_kill()
nrwahl2
committed
bed681b
API: libcrmcommon: Deprecate mainloop_child_t API
nrwahl2
committed
1d0b82c
Refactor: libcrmcommon: Make free_main_loop_child() a GDestroyNotify
nrwahl2
committed
840bbec
Refactor: libcrmcommon: Reorder some mainloop.c functions
nrwahl2
committed
051ca95
Refactor: libcrmcommon: Move pcmk__mainloop_child_exit_fn_t
nrwahl2
committed
1df7e28
Refactor: libcrmcommon: mainloop_child_t -> pcmk__main_loop_child_t
nrwahl2
committed
4de76fc
Refactor: libcrmcommon: Rename pcmk__mainloop_child_exit_fn_t
nrwahl2
committed
a96a196
Refactor: libcrmcommon: Rename pcmk__main_loop_child_t:exit_fn
nrwahl2
committed
db80ae4
Refactor: libcrmcommon: Drop pcmk__mainloop_timer_get_period()
nrwahl2
committed
f692591

Commits on Aug 18, 2026

Refactor: libcrmcommon: Lightly reformat main loop timer functions
nrwahl2
committed
f699c94
Refactor: libcrmcommon: Don't start main loop timer if callback is NULL
nrwahl2
committed
eb9c522
Refactor: libcrmcommon: Drop repeat variable from mainloop_timer_cb()
nrwahl2
committed
3991bf9
Refactor: various: Always pass repeat=true to mainloop_timer_add()
nrwahl2
committed
2a47ae9
Refactor: various: Use G_SOURCE_{CONTINUE,REMOVE} in GSourceFuncs
nrwahl2
committed
cca1f56
Refactor: controller: Drop fsa_timer_t:callback
nrwahl2
committed
b0200f1
Refactor: controller: Drop redundant inits in controld_init_fsa_timers()
nrwahl2
committed
abcdf2e
Refactor: controller: controld_init_fsa_timers() returns void
nrwahl2
committed
70dfac4
Refactor: controller: Drop overridden set of finalization timer input
nrwahl2
committed
2c186de
Refactor: controller: Drop get_timer_desc()
nrwahl2
committed
de2b2b6
Refactor: controller: New new_fsa_timer()
nrwahl2
committed
8fd6ebe
Refactor: controller: New free_fsa_timer()
nrwahl2
committed
8876cdc
Refactor: attrd, pacemakerd: Rename two main loop timers
nrwahl2
committed
245d5d3
Refactor: libcrmcommon: New pcmk__main_loop_timer_new()
nrwahl2
committed
aa00961
Refactor: libcrmcommon: New pcmk__main_loop_timer_running()
nrwahl2
committed
c0226e3
Refactor: libcrmcommon: New pcmk__main_loop_timer_free()
nrwahl2
committed
2c3f5e1
Refactor: various: Drop mainloop_timer_set_period() internally
nrwahl2
committed
5d3aa11
Refactor: fencer: Drop dead code from get_agent_metadata_cb()
nrwahl2
committed
22e782b
Refactor: libcrmcommon: New pcmk__main_loop_timer_start()
nrwahl2
committed
454fef1
Refactor: libcrmcommon: New pcmk__main_loop_timer_stop()
nrwahl2
committed
c2f5eaf
Refactor: libcrmcommon: New main_loop_timer_cb()
nrwahl2
committed
bf19a0c
Refactor: controller: Use "interval" instead of "period" for timers
nrwahl2
committed
8280f33
Refactor: libcrmcommon: Use "interval" instead of "period" for timers
nrwahl2
committed
4541343
Refactor: libcrmcommon: Rename mainloop_timer_t:userdata to user_data
nrwahl2
committed
2ed962f
Refactor: libcrmcommon: Rename mainloop_timer_t:id to source_id
nrwahl2
committed
cad6acb
Refactor: libcrmcommon: New pcmk__main_loop_timer_t
nrwahl2
committed
cafad30

Commits on Aug 19, 2026

API: libcrmcommon: Deprecate mainloop_timer_t API
nrwahl2
committed
85bd3ea