Skip to content

Text Input | Support multiLine on validate-later - #77

Merged
BrianGenisio merged 1 commit into
mainfrom
fix/text-input-multiline-validate-later
Oct 2, 2026
Merged

BrianGenisio merged 1 commit into
mainfrom
fix/text-input-multiline-validate-later

Conversation

@BrianGenisio

Copy link
Copy Markdown
Contributor

Summary

multiLine=true now works on [kind: validate-later] text inputs, not only [kind: string]. Authors writing open-ended / review-later prompts can get a textarea the same way scored string answers do.

Changes

The markdown option was already parsed. The learner UI only checked kind === 'string' before creating a <textarea>, so validate-later always rendered a single-line field. That gate now includes validate-later. The editor exposes the Multi-line checkbox for that kind too.

New example: data/examples/text-input-multiline-validate-later.md.

Testing

  • Select text-input-multiline-validate-later in examples mode; confirm each field is a resizable multi-line textarea
  • Confirm a plain [kind: validate-later] without multiLine stays single-line
  • In the editor, set kind to Validate Later and toggle Multi-line; markdown should include multiLine=true
  • node --test test/text-input-validation.test.js

Co-authored-by: Cursor <cursoragent@cursor.com>
@BrianGenisio
BrianGenisio marked this pull request as ready for review October 2, 2026 15:13
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 914161fa-467a-46d5-bf27-0bb964083d92

📥 Commits

Reviewing files that changed from the base of the PR and between 041b95b and c3aea0e.

📒 Files selected for processing (4)
  • data/examples/text-input-multiline-validate-later.md
  • public/editor.js
  • public/modules/text-input.js
  • test/text-input-validation.test.js

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The editor now displays the Multi-line checkbox for string and validate-later questions. The text-input module selects multiline input for validate-later questions when the option is enabled. A test checks parsing of the option, and a new example defines three multiline validate-later questions.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to c3aea

No concrete merge-blocking defect was identified in the multiline validate-later change.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: adding multi-line support for validate-later text inputs.
Description check ✅ Passed The description accurately explains the multi-line behavior change, editor update, new example, and testing steps. It is directly related to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit 3037e93 into main Oct 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant