Manchester | 26-ITP-May | Joanne O'Malley | Sprint 2 | Book Library - #504
Open
joanne342 wants to merge 7 commits into
Open
Manchester | 26-ITP-May | Joanne O'Malley | Sprint 2 | Book Library#504joanne342 wants to merge 7 commits into
joanne342 wants to merge 7 commits into
Conversation
joanne342
added
the
Needs Review
cjyuan
reviewed
Aug 3, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Well done! Just some minor issues.
According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?
Comment on lines
+48
to
-39
| if (isNaN(pagesNum) || pagesNum <= 0) { | ||
| alert("Please enter a valid page count greater than 0."); | ||
| return false; | ||
| } else { |
Contributor
There was a problem hiding this comment.
What type of numbers should a page count be?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Book library