London | 26-ITP-May | Dipa Sarker | Sprint 3 | Alarm Clock App by Dipa-Sarker · Pull Request #1294 · CodeYourFuture/Module-Data-Groups

Dipa-Sarker · 2026-07-26T11:55:08Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Implemented the alarm clock functionality with countdown and alarm controls.

** Changes made**

Added functionality for the Set Alarm button to start the countdown from the entered time.
Updated the timer display to show the remaining time in "mm:ss" format.
Added a countdown that decreases every second.
Triggered the alarm sound when the timer reaches "00:00".
Added Stop Alarm button functionality to stop the alarm sound and stop countdown after certain time.

I also tested the functions to works the app properly.

LonMcGregor

Good start on this task, there is still some work to do however

LonMcGregor · 2026-07-27T13:36:07Z

+    .padStart(2, "0");
+  const showTimeSeconds = (remainingTime % 60).toString().padStart(2, "0");
+  timeRemainingElement.innerText = showTimeMinutes + ":" + showTimeSeconds;
+  if (remainingTime === 0) {


Do you properly finish the timer countdown after it hits zero?

Sorry, I am unclear about your question. But I think I finished the countdown after hitting zero at here:

function countDown() {
if (remainingTime <= 0) {
clearInterval(intervalID);
triggerAlarm();
return;
}

Which means:

Timer reaches 00:00

Interval stops

No negative counting

Alarm starts

returns from the code so no extra code runs afterward.

I see, I was confused that you have a triggerAlarm in the setAlarm function. if you also have it in the countDown function, is it necessary to have it in the setAlarm function also?

if (remainingTime <= 0) {
clearInterval(intervalID);
triggerAlarm();
return;
}
this condition serves different purpose inside setAlarm() function. I commented out every possible confusing condition in my code. Please let me know if there any confusion again.

LonMcGregor · 2026-07-27T13:36:29Z

+
+let remainingTime;
+let intervalID;
+function triggerAlarm() {


A bit more spacing between functions / improved formatting would help readability.

Actually, I used prettier tool according to the style guide for formatting. Should I provide extra spaces in between functions?

A clear line between functions is a good idea

I placed one line inside functions.

LonMcGregor · 2026-07-27T13:36:48Z

 window.onload = setup;
+
+const timeRemainingElement = document.querySelector("#timeRemaining");
+const alarmSetElement = document.querySelector("#alarmSet");


If you know you are using IDs, can you think of something better tha n querySelector?

Is it getelementID()?

Replaced every querySelector() by getElementID().

LonMcGregor

Good improvement with the input validation, almost complete with the other tasks

LonMcGregor · 2026-08-01T09:00:54Z

+    .padStart(2, "0");
+  const showTimeSeconds = (remainingTime % 60).toString().padStart(2, "0");
+  timeRemainingElement.innerText = showTimeMinutes + ":" + showTimeSeconds;
+  if (remainingTime === 0) {


I see, I was confused that you have a triggerAlarm in the setAlarm function. if you also have it in the countDown function, is it necessary to have it in the setAlarm function also?

LonMcGregor · 2026-08-01T09:01:09Z

+
+let remainingTime;
+let intervalID;
+function triggerAlarm() {


A clear line between functions is a good idea

done building alarm clock app

3135818

Dipa-Sarker added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 26, 2026

LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 27, 2026

LonMcGregor reviewed Jul 27, 2026

View reviewed changes

add input validation

f71af08

Dipa-Sarker added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 30, 2026

LonMcGregor reviewed Aug 1, 2026

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 1, 2026

Dipa-Sarker added 2 commits August 2, 2026 12:23

commented for conditions

8eae099

replaced getElementByID

0c28ad1

Dipa-Sarker added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 2, 2026

Uh oh!

Uh oh!

Conversation

Dipa-Sarker commented Jul 26, 2026

Learners, PR Template

Changelist

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants